orginal comment:GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

-> GitLab CI is not connected to run tests. thanks again @avpaderno for restarting this.

Issue fork dropdown_language-3475886

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alyaj2a created an issue. See original summary.

alyaj2a’s picture

alyaj2a commented
Assigned: Unassigned » alyaj2a

alyaj2a opened merge request !32

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Coding Standard issues » Fix the issues reported by PHP_CodeSniffer
Status: Active » Needs review

avpaderno opened merge request !33

avpaderno changed the visibility of the branch 3475886-gitlab-ci-reports to hidden.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

skaught made their first commit to this issue’s fork.

skaught’s picture

skaught
Primary language English
commented
Status: Needs review » Needs work
skaught’s picture

skaught
Primary language English
commented
Assigned: alyaj2a » Unassigned
skaught’s picture

skaught
Primary language English
commented
Issue summary: View changes
skaught’s picture

skaught
Primary language English
commented
Title: Fix the issues reported by PHP_CodeSniffer » Fix the issues reported by PHP_CodeSniffer, gitlab setup needs attention
skaught’s picture

skaught
Primary language English
commented
Status: Needs work » Closed (outdated)

gitlab concerns should be it's own ticket, and otherwise this is dated and should now be rerun across current branch heads.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

skaught’s picture

skaught
Primary language English
commented
Related issues: +#3569485: Project 'dropdown_language' Gitlab test integration