Problem/Motivation

PHP 8.2 is the minimum required but TFA module requires 7.0+.

Steps to reproduce

Proposed resolution

PHP 8.1 is the minimum required for Drupal 10. Since it's a migration module, it should be the same except if you're using special php 8.2 features.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork tfa_migration-3474729

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jibus created an issue. See original summary.

bhanu951 made their first commit to this issue’s fork.

bhanu951’s picture

bhanu951 commented
Status: Active » Needs work

bhanu951 opened merge request !4

bhanu951’s picture

bhanu951 commented

@jibus Thanks for reporting. I downgraded the required PHP version.

Are you using this module in one of your projects ? or you just came across this module ?

I wanted to know if you have faced any issues in TFA validation after migration, in case you are using this module.

I tried it in our project and it works as expected.

Would like to get confirmation from others as well. As lab testing doesn't cover all the production site cases.

Spent a lot of time on this module and would like to know how productive the time spent was.

bhanu951’s picture

bhanu951 commented
Status: Needs work » Needs review
jibus’s picture

jibus commented

@bhanu951, thank you for your answer.

Yes I am actually migrating an D7 instance with 1K users with TFA enabled.

I will let you know if I encounter any problem.

In the end, I switched from php 8.1 to 8.2 without any problem.

If you don't to push this, you can close the issue.

Thank you again.

  • bhanu951 committed 7f3e20cc on 1.x 
    Issue #3474729 by bhanu951, jibus: Why PHP 8.2 is the minimum required ?
bhanu951’s picture

bhanu951 commented
Status: Needs review » Fixed

For compatibility I have downgraded the PHP version and merged the code.

@jibus Sure will be waiting for your feedback.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.