The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
We need documentation to onboard people to the Starshot Demo Design System project.
This issue is focused on the merge request guide.
Steps to reproduce
Proposed resolution
Although there are existing docs, let's make this simpler for people with step-by-step for:
- Creating a merge request
- Contributing to merge requests
Remaining tasks
- Gather info and links
- Create draft in Google docs
- Port to community initiative guides
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screen Shot 2024-08-07 at 4.35.39 PM.png | 114.91 KB | siramsay |
Comments
Comment #2
kristen polDocs are here and ready for review:
https://www.drupal.org/community-initiatives/starshot-demo-design-system...
https://www.drupal.org/community-initiatives/starshot-demo-design-system...
Comment #4
kristen polNote that Jacob has reviewed and suggesting moving the merge request creation to after the code changes which is a good idea so will do that tomorrow probably.
Comment #5
kristen polSome other feedback from Jacob:
1. Quotes need fixing.
2. He didn't see the yellow merge request number because the pipeline was running so update doc to reflect this.
3. It wasn't clear to him how to change the status, assigned, etc.
Comment #6
siramsay commentedStep 2
2. Find the issue where you want to contribute code [example issue]
Example issue is a fixed issue and doesn't have Create issue fork
Comment #7
kristen polThanks. I was just pointing at an issue that was used for this type of work… I used it when creating the documentation… perhaps I’ll remove the link to avoid confusion
Comment #8
kristen polAssigning back to me but this is still being reviewed by others so will hold off on changes for now.
Comment #9
siramsay commentedI think removing link is best. For someone new/beginner, it can be confusing. I've been there.
Comment #10
sea2709 commentedI haven't contributed to merge requests before. Is there a sample issue that I can do some trials? I read through the guide and got the ideas, just want to do it by myself!
Comment #11
kristen polThanks @siramsay. Will do!
@sea2709 Let me find or create an issue for you to test this out :)
Moving this back to needs work for me to make changes.
Comment #12
kristen pol@sea2709 Please use this one to test:
https://www.drupal.org/project/demo_design_system/issues/3465333#comment...
Comment #13
kristen polI have made all the changes above except for reordering when you create the MR. I'll wait on @sea2709's feedback before doing that.
Comment #14
kristen polBack to needs review.
Comment #15
kristen pol@sea2709 Did you have any additional feedback based on the MR you did?
Comment #16
sea2709 commented@Kristen: I just have only one comment, I think step 6 should be placed after step 15 (or at least, that is what I did). After I push changes, I will be able to create a MR.
Comment #17
kristen pol@sea2709 Gotcha. So just the reordering of MR creation that Jacob also pointed out. I'll move back to needs work for reworking that.
Comment #18
kristen pol@sea2709 Would you have time to rework the guide so the MR is created after the code branch is created and changes are added?
We've been doing that but I haven't had time to update the docs.
Comment #19
kristen polGoing to call this one fixed for now. If someone wants to update to not do the draft MR, just reopen and update the docs.