The existing Announcements are being opened in a settings try at the right of the screen. Since the Announcement feed link has been moved into the new navigation into the left of the screen, the contents of the announcement feed show really far on the right side of the screen.
Move the contents of the Announcement feed into the Navigation submenu/drawer. The design of the drawer would look like this:
Note: please ignore the "icon" for the announcement with the letters: it's there to only showcase what should happen when there is no link. Please keep the speaker as an icon.
This designs add new styles to the Navigation for links, so that's why this issue is on the Navigation issue queue:
Link to Figma specs: https://www.figma.com/design/VCPAxetieAC2pzw7hgX3ij/Drupal-Admin-UI---De...
Update initial implementation with new designs
Navigation will have links styled.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | links.png | 49.98 KB | ckrina |
| #7 | announcements.png | 177.03 KB | ckrina |
| #6 | Снимок экрана 2024-08-05 в 12.35.27.png | 355.74 KB | kostyashupenko |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
ckrinaNot sure if the component needs to be Navigation or Announcements, so leaving into Navigation for now because we need to provide the designs and styles at least.
Comment #3
quietone commentedComment #4
kostyashupenkoIn progress
Comment #6
kostyashupenkoHere is very raw implementation https://git.drupalcode.org/project/drupal/-/merge_requests/9069
I'm fetching the list of announcements and simulating from them the child menu for parent `Announcements` link. For now visually it is looking similar as other dropmenus.
I prepared this MR mostly to give front devs to do their job separately. Now we have the full data available in twig and we can build UI fully matched desired design, while backenders can work on the implementation.
Here are few thoughts:
1. For the old `toolbar` module `announcements_feed` module is injecting the whole structure from inside, instead of `toolbar` module is relying on `announcements_feed`. Should we have the same logic? Like to put child menu into our navigation sidebar from using code written in `announcements_feed` module ?
2. In the old `toolbar` module `Annoucements` link doesn't have child menu by default. Instead it's a link to another page '/admin/announcements_feed' and in the same time it's an ajax link which is getting on response dialog with child menu links. Should we have ajax here aswell? For now there is no ajax in my MR.
3. Specific design for child menu of `Annoucements` will require probably new unique `theme hook` <- so potentlially it will not be a part of `navigation-menu.html.twig` component.
Keeping ticket on `Active` status since it requires discussions / Design.
Comment #7
ckrinaAdded designs to the issue summary. This is ready to be worked on.
Comment #8
ckrinaI think this issue should be moved into the Announcements issue queue, no?
Comment #10
kentr commented