Problem/Motivation

Presently, the build dependencies of this module are very out of date. The latest version of node that can build the assets is Node 10. This is inherently insecure for anyone wishing to develop this module further.

Now that the latest release doesn't support Drupal 9, there are no remaining blockers.

Proposed resolution

Eliminate the build step entirely. Drupal core no longer supports ES5. There is no longer a need for a build step at all.

Remaining tasks

  1. Remove build step.
  2. Test
  3. Commit
  4. Release

User interface changes

None

API changes

None

Data model changes

None

Issue fork media_library_form_element-3458296

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Luke.Leber created an issue. See original summary.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Title: Update build dependencies to work with a supported Node version » Update build dependencies to work with a supported Node version or drop ES5 support?
Issue summary: View changes
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Title: Update build dependencies to work with a supported Node version or drop ES5 support? » [PP-1] Update build dependencies to work with a supported Node version or drop ES5 support?
Status: Active » Postponed

Postponed on https://www.drupal.org/project/media_library_form_element/issues/3432301

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Title: [PP-1] Update build dependencies to work with a supported Node version or drop ES5 support? » Completely drop ES5 transpiration
Issue summary: View changes
Status: Postponed » Active

Luke.Leber credited mark_fullmer.

Luke.Leber credited sreeram_v.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

Transferring issue credits from https://www.drupal.org/project/media_library_form_element/issues/3432301

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Active » Needs review

I am mobile now and had a bit this evening to myself. Trying to move this issue along.

I've simply moved the ES6 asset in place of the ES5 and deleted the build stuff. Hope to be able to test against a real site soon, unless someone beats me to it 🙏.

Luke.Leber opened merge request !16

Luke.Leber credited Heine.

Luke.Leber credited larowlan.

Luke.Leber credited Martygraphie.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

Adding missing issue credits from security.drupal.org

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Title: Completely drop ES5 transpiration » Drop ES5 transpilation
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

This change is long overdue, and when this MR is updated to include the latest commits on 2.x, tests are passing. The code changes look great. Merging!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.