Problem/Motivation

After the 10.3 update, which upgraded CKEditor from 41.2.0 to 41.3.1, the iFrame button is breaking the editor. The text becomes empty. If I switch between text formats the editor is duplicated (see screenshot). There's a console error:

Uncaught CKEditorError: e.getFirstPosition() is null
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-e.getFirstPosition() is null
    getRelatedElement http://mysite.docker.localhost:8000/modules/contrib/ckeditor_iframe/js/build/iframeembed.js?sfn2ht:1
    getRelatedElement http://mysite.docker.localhost:8000/modules/contrib/ckeditor_iframe/js/build/iframeembed.js?sfn2ht:1
    _updateToolbarsVisibility http://mysite.docker.localhost:8000/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=41.3.1:5
... etc... let me know if more of this would be helpful

I can't replicate this on a clean install of Drupal 10. I can replicate it on another older site that would have been upgraded from CKEditor 4.

This is happening with the 2.x and 3.x versions of this module.

CommentFileSizeAuthor
#18 getFirstPosition-is-null-3457032.18.patch57.75 KBdonpas
#4 Create Article My Drupal 10.3 Site.png26.81 KBckhalilo
ckeditor-iframe-duplication .png29.95 KBmegan_m

Issue fork ckeditor_iframe-3457032

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

megan_m created an issue. See original summary.

megan_m’s picture

megan_m commented
Issue summary: View changes
megan_m’s picture

megan_m commented
Issue summary: View changes
ckhalilo’s picture

ckhalilo
Primary language French
Location France
commented
StatusFileSize
new Create Article My Drupal 10.3 Site.png26.81 KB

I got the same error when i migrate to Drupal 10.3
Image duplicate body

angheloko made their first commit to this issue’s fork.

angheloko opened merge request !7

angheloko opened merge request !8

angheloko closed merge request !7

angheloko closed merge request !8

angheloko opened merge request !9

marieascomedia’s picture

marieascomedia commented

Works for me.
Thank you.

ded’s picture

ded commented

We are having this issue also with 3.0.0-beta1. Our console error is slightly different:

TypeError: Cannot destructure property 'parent' of 'selection.getFirstPosition(...)' as it is null.
    at getClosestSelectedIframeEmbedWidget (iframeEmbedUtils.js:78:11)
    at Object.getRelatedElement (iframeEmbedToolbar.js:78:102)
    at q._updateToolbarsVisibility (ckeditor5-dll.js?v=41.3.1:5:718206)
    at r.<anonymous> (ckeditor5-dll.js?v=41.3.1:5:717231)
    at r.fire (ckeditor5-dll.js?v=41.3.1:5:663135)
    at r.update (ckeditor5-dll.js?v=41.3.1:5:602960)
    at Object.fire (ckeditor5-dll.js?v=41.3.1:5:663135)
    at de (ckeditor5-dll.js?v=41.3.1:5:201940)
    at pe.fire (ckeditor5-dll.js?v=41.3.1:5:201331)
    at St.<anonymous> (ckeditor5-dll.js?v=41.3.1:5:255790)
lazzyvn’s picture

lazzyvn commented

I have same error with drupal 10.3

earthday47’s picture

earthday47
Location New York
commented
Status: Active » Reviewed & tested by the community

I can also confirm that the merge request resolves the issue!

This seems to be a common issue with plugins, such as https://www.drupal.org/project/ckeditor_bs_grid/issues/3389827, and checking for the existence of the object is the resolution.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Priority: Normal » Major

The input field is empty when this error is happening, Major if not critical so bumping the Priority.

aporie’s picture

aporie
Primary language French
commented

+1 RTBC

shani maurya’s picture

shani maurya
Location Mumbai
commented

I can also confirm that the merge request resolves the issue for D10.3

donpas’s picture

donpas commented
StatusFileSize
new getFirstPosition-is-null-3457032.18.patch57.75 KB

Made a patch for those still facing this issue with version 3.0.x.

donpas’s picture

donpas commented
Status: Reviewed & tested by the community » Needs review
aporie’s picture

aporie
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

Hi Donpas,

There is a MR available. You can find the patch by clicking on "plain diff".

carlosmonroy’s picture

carlosmonroy commented

hello,
We encountered the same problem when updating core 10.3.
we had ckeditor_iframe in alpha1

By updating ckeditor_iframe and using the patch in comment #18, ckeditor works again.

caspervoogt’s picture

caspervoogt commented

Patch from #18 works for me.. RTBC IMHO

vanessa.fayard’s picture

vanessa.fayard commented

I've applied the MR!9 as patch and it applied successfully with no errors.

Tested on Drupal 10.3.2 with drupal/ckeditor_iframe: ^3.0@beta

Thanks

ccarnnia’s picture

ccarnnia commented

++ #23
applied the patch to D10.3.5 successfuly.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Sorry all, I'll get a new release out today for this.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

  • bkosborne committed a31e2fec on 3.0.x authored by angheloko 
    Issue #3457032 by angheloko: CKEditorError: selection.getFirstPosition...
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Reviewed & tested by the community » Fixed
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Included in 3.0.0-beta2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.