Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hello all, it’s time for the fortnightly coding standards meeting.
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.
Current ping list: @catch, @larowlan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.
| Kingdutch | :wave: ello |
| borisson_ | :wave: hello |
| mstrelan | :wave: helloo |
1️⃣ What topics do you want to discuss? Post in this thread and we’ll open threads for them as appropriate.
2️⃣ Action items
2️⃣.1️⃣ Approve minutes for previous meeting(s)
| quietone | #3456119: Coding Standards Meeting Tuesday 2024-06-18 2100 UTC |
| quietone | #3443047: Coding Standards Meeting Wednesday 2024-05-08 0900 UTC |
2️⃣.2️⃣ TBD
3️⃣ Fixed since last meeting
4️⃣ RTBC issues
4️⃣.1️⃣ #3339746: Coding style for PHP Enumerations
| quietone | I just updated the wiki page. That should be checked, then we can publish the CR. |
| quietone | And move to the next task. |
| mstrelan | I checked the wiki page, looks good and matches the proposed change. The link to the classes section also works correctly. |
4️⃣.2️⃣ #3324368: Update CSS coding standards to include PostCSS and Drupal 10
| quietone | Waiting on the creators of the CSS standards to finish this. |
5️⃣ New Issues5️⃣. 1️⃣
6️⃣ In progress6️⃣.1️⃣ #1991932: Standard for assigning references to variables
| quietone | There is a proposed text for review. |
| borisson_ | I think the proposed text looks good :+1: |
| borisson_ | This doesn't have to go trough voting because it's just a clarification I guess? |
| quietone | It does seem like a clarification. |
| quietone | So, yea. If the committee agrees I think we can skip step 6. |
6️⃣.2️⃣ #1567920: Naming standard for abstract/base classes
| quietone | In the previous meeting @Björn Brala (bbrala) pointed out the complications with this. |
| quietone | There is support on the issue for such a standard. |
| quietone | Suggestions? How to resolve this? |
| quietone | How about. Does anyone here support this proposal? |
| Kingdutch | I'm against. Primarily because it feels like we're trying to force naming depending on implementation whereas (contrary to interfaces) the implementation does not have a single possible usage. So naming should follow the intended usage.
Something can be abstract but not be a base class in the Drupal base class sense. Similarly a base class could be non-abstract (just the default implementation). Interfaces make sense because it clearly indicates "A contract" so for every interface I could rename them from "SomethingInterface" to "SomethingContract" and it would still be true (since implementation and intention have a 1:1 relationship). I think the second reason to reject this is that we haven't been able to get a clear consensus in 12 years? 🙂 So it also looks like our current system might be good enough with people deciding on the class name based on the intended usage and whether it's abstract or not depends on the implementation. |
| borisson_ | I agree with ^, I think trying to make this a hard rule will be really difficult |
| Björn Brala (bbrala) | No support from me.. can of worms :sweat_smile: |
6️⃣.3️⃣ #1539738: list() syntax
| quietone | Needs review or suggested text |
| Kingdutch |
|
| Kingdutch | I had to think out loud :grimacing: Here's the fully formed thought: #1539738: list() syntax#comment-15667383 |
6️⃣.4️⃣https://www.drupal.org/project/coding_standards/issues/782016
| quietone | Where is an example of such an override? |
| mstrelan | Drupal 7 |
| mstrelan | https://git.drupalcode.org/project/drupal/-/blob/7.x/themes/bartik/templ... |
| Kingdutch | Is this relevant for 10+? Otherwise given that 7 will be out of date in January we should just close it? :meow_peek: |
6️⃣.5️⃣ #1365340: Decide on guidelines for regex formatting
| quietone | Needs proposed text |
Comments
Comment #2
quietone commentedDiscuss #1567920: Naming standard for abstract/base classes
Comment #7
quietone commentedComment #8
quietone commentedComment #9
longwave