Problem/Motivation

We have some incoming issues for Drupal 10.3. Every test that hits project_browser_test.time service is failing with:

Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "project_browser_test.time", path: "session -> session_manager -> project_browser_test.time -> state -> cache.bootstrap -> cache.backend.database".

   │
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:149
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:438
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:239
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:179
   │ /var/www/html/web/core/lib/Drupal/Core/Cache/ChainedFastBackendFactory.php:98
   │ /var/www/html/web/core/lib/Drupal/Core/Cache/CacheFactory.php:110
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:257
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:179
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:438
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:239
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:179
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:438
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:239
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:179
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:438
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:239
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:179
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:438
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:239
   │ /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:179
   │ /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php:1003
   │ /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php:849
   │ /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:622
   │ /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:248
   │ /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
   │ /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
   │ /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
   │ /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
   │ /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
   │ /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
   │

Steps to reproduce

  1. Setup with https://github.com/ddev/ddev-drupal-contrib
  2. Change to 10.3 in config.contrib.yaml
  3. ddev restart
  4. ddev poser (I hack this command, adding composer info to confirm I'm getting the Drupal version i want.
  5. ddev phpunit

Proposed resolution

Issue fork project_browser-3450499

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sime created an issue. See original summary.

sime’s picture

sime
any/any
Location Melbourne
commented
Issue summary: View changes
sime’s picture

sime
any/any
Location Melbourne
commented

(With help from richard thomas and mstrelan in Slack) in 10.3 the time service is added to cache.backend.database this causes the loop. Quote "
decorated version requires state it causes the loop, because state then requires the cache which requires datetime.time again".

sime’s picture

sime
any/any
Location Melbourne
commented
Priority: Normal » Major

Calling this major because 10.3 is already beta.

mstrelan made their first commit to this issue’s fork.

mstrelan opened merge request !487

sime’s picture

sime
any/any
Location Melbourne
commented
Parent issue: » #3423697: GitLab CI - test for previous and next minor versions, and maximum PHP version
sime’s picture

sime
any/any
Location Melbourne
commented
Category: Bug report » Task
Status: Active » Needs review

So technically this is a part of #3423697: GitLab CI - test for previous and next minor versions, and maximum PHP version that I stumbled onto because i'm daft and was running next minor unwittingly. So I've rebased and updated #3423697 and made this a child of it.

sime’s picture

sime
any/any
Location Melbourne
commented
Status: Needs review » Closed (outdated)

Fixed differently in HEAD.