Problem/Motivation

config_inspector complains:
protected_forms.settings

protected_forms.langcode 	Undefined 	undefined 	No 	en 	missing schema 	'langcode' is not a supported key.
	protected_forms.allowed_patterns 	Undefined 	undefined 	No 	website 	missing schema 	'allowed_patterns' is not a supported key.

All other keys are fine!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork protected_forms-3436411

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

Grevil made their first commit to this issue’s fork.

Grevil opened merge request !15

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

Done, please review!

grevil’s picture

grevil commented

Found another small schema bug. Also fixed! Tests should be green again. :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Changes LGTM, but tests fail:

There was 1 error:
1) Drupal\Tests\protected_forms\Functional\ProtectedFormsTest::testNodeCommentRejectedSubmissionPrintsCorrectMessage
Error: Call to undefined method Drupal\Tests\protected_forms\Functional\ProtectedFormsTest::t()
/builds/project/protected_forms/tests/src/Functional/ProtectedFormsTest.php:39
/builds/project/protected_forms/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
ERRORS!

grevil’s picture

grevil commented
Title: Fix schema » Fix schema and add generic functional test
Status: Needs work » Needs review

Ok, these tests didn't run for quite a long time (edited 4 years ago). So they had a few flaws.

I added some automatic phpcs fixes and a generic test class in for good measures, please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

  • Anybody committed 65506d95 on 2.0.x authored by Grevil 
    Issue #3436411 by Grevil, Anybody: Fix schema and add generic functional...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Perfect, can you tag a new release please @Grevil?

grevil’s picture

grevil commented

Sure thing!

grevil’s picture

grevil commented

Done https://www.drupal.org/project/protected_forms/releases/2.0.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.