Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new1.22 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120024

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

project update bot’s picture

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-137198

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.10
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-145706

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.10
  3. palantirnet/drupal-rector: 0.20.1
superfedya’s picture

Issue summary: View changes

Is there any Drupal 11 and Drush 13 compatibility for 2.x version?

rajab natshah’s picture

Priority: Normal » Major
rajab natshah’s picture

Drupal ~10.3 and 10.4 were released.
Updated the core version requirement to ^10.3 || ^11, and removed the deprecation message, and replace it with Error::logException

rajab natshah’s picture

Version: 8.x-1.x-dev » 2.x-dev

rajab natshah changed the visibility of the branch project-update-bot-only to hidden.

rajab natshah changed the visibility of the branch 2.x to hidden.

rajab natshah’s picture

Priority: Major » Critical
rajab natshah’s picture

Status: Needs review » Reviewed & tested by the community

Hoping for a tag release soon to simplify and accelerate testing and updates in projects.

flyke’s picture

Please note that without patch, 2.x-dev is already D11 compatible according to requirements.
Anyway: I can confirm that I could apply MR 17 to 2.x-dev.

I had a D10.4 project that I updated to D11.1
BUT after updating to D11 and updating ckeditor_media_embed to 2.x-dev (with this MR applied) my site was unusable because of errors caused by ckeditor_media_embed.

I created issue #3499886 for those errors that seem to be an immediate result of upgrading to D11 or updating ckeditor_media_embed to 2.x-dev (not sure which one).

superfedya’s picture

There is no way that this module is Drupal 11 ready. I got tons of errors.

Error: Call to undefined function Drupal\ckeditor_media_embed\watchdog_exception() in Drupal\ckeditor_media_embed\Embed->getEmbedObject() (line 140 of /mysite/modules/contrib/ckeditor_media_embed/src/Embed.php).

rajab natshah’s picture

rajab natshah’s picture

rajab natshah’s picture

The module was tested under Drupal 11 in a number of projects. ( using alternative methods )
Hoping for a tag release to push the module for more use under Drupal 11, and maybe it could be suggested to work under Drupal CMS

rajab natshah’s picture

Hoping for tag release to work with Drupal 11.2.0

rajab natshah’s picture

Can we offer to help maintaining this module? to do the release and next needed releases.

grndlvl’s picture

Status: Reviewed & tested by the community » Fixed
n.ghunaim’s picture

StatusFileSize
new3.01 KB

Error: Call to undefined function Drupal\ckeditor_media_embed\watchdog_exception() in Drupal\ckeditor_media_embed\Embed->getEmbedObject() (line 140 of /app/docroot/modules/contrib/ckeditor_media_embed/src/Embed.php).

rajab natshah’s picture

Noor, Please, update to ckeditor_media_embed-2.0.3 first. ( Jonathan, had a fresh new release with support for Drupal 11 )
More testing rounds.

Please, file new issues, If you face any further issues, or other integration issues with other modules.
But do not list them in this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.