Problem/Motivation
The embedded video shows a 404 error when clicked on.
This occurs when the user is logged in.
This issue occurs because the JavaScript code is executing multiple times.
Steps to reproduce
- Add a block that has a media field
- Add a remote video (YouTube)
- Attempt to play the video
Proposed resolution
Prevent multiple executions.
Remaining tasks
- ✅ File an issue about this project
- ❌ Addition/Change/Update/Fix to this project
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Code review from 1 Varbase core team member
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes and Update Helper on new feature change/addition
- ❌ Release
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- N/A
| Comment | File | Size | Author |
|---|---|---|---|
| prevent-multiple-executions.patch | 3.64 KB | mutasim al-shoura |
Issue fork varbase_media-3425225
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rajab natshahComment #3
rishabjasrotia commentedComment #4
rishabjasrotia commentedHello @rajab-natshah,
The patch you have added does not belong to this module source code.
I am not able to apply this patch!
Comment #5
rishabjasrotia commentedComment #6
rajab natshahNo further support for the Varbase Media
9.0.xbranch.If this patch is for the
9.1.xbranch, It will be reviwed.If not it will be closed as want fix.
Comment #7
mutasim al-shoura commentedSorry, the code is related to this issue. I updated the patch there.
https://www.drupal.org/project/varbase_media/issues/3260536
Comment #8
rajab natshahNoted; Mutasim
Thanks, for reporting and patching.
Thank you, Rishab, for testing the patch.
You may close this issue as won't fix or as doublicated
Let us move the converstion to #3260536: Add an experimental Lazy Load OEmbed field formatter for remote videos in Varbase Media
We may add it to the
9.1.xbranch and maybe to10.0.xAs we drpped support for Drupal 9 ( only trying to save time for Varbase
9.1.xand Varbase10.0.x)Comment #9
rishabjasrotia commentedClosing this issue since no relevant code changes needed.