Problem/Motivation

Per https://www.hojtsy.hu/blog/2024-feb-12/onwards-drupal-11-ways-get-involved, Drupal 11 will likely require PHP 8.3

This means this module can adopt new language-level features:

  1. https://www.php.net/releases/8.2/en.php
  2. https://www.php.net/releases/8.3/en.php

Combine this with:

  1. Drupal 11 will drop the Tour module, for which the CDN module already has #3216302: Remove Tour support
  2. Drupal 10.2 brought explicit config validation support in Drupal core, and made it easy to use thanks to #config_target, for which the CDN module already has #3394172: Adopt Drupal core 10.3 config validation infrastructure

Then it perhaps makes little sense to make a 5.x version do #3216302: Remove Tour support and #3394172: Adopt Drupal core 10.3 config validation infrastructure? On the other hand, those things are possible today, bumping the PHP requirement to PHP 8.3 seems silly today. OTOH, per https://packagist.org/php-statistics, PHP 8.2 adoption already is close to matching PHP 8.1 adoption. PHP 8.3 adoption is growing quickly.

So the choices are:

  1. 5.x requiring PHP 8.2 and >=10.2, 6.x for >=11 requiring PHP 8.3
  2. 5.x requiring PHP 8.3 and >=11, no 6.x any time soon
  3. 5.x requiring PHP 8.3 and >=10.2 >=10.3, no 6.x any time soon

Steps to reproduce

N/A

Proposed resolution

In the spirit of gradual evolution and having new releases support two Drupal core majors simultaneously, I think choice #3 is preferable. See comments #4 + #8.

Remaining tasks

Gather feedback from users of the CDN module.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork cdn-3421351

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wim Leers created an issue. See original summary.

Wim Leers credited Gábor Hojtsy.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Drupal 11
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: 5.x requiring PHP 8.2 and >=10.2, 6.x requiring PHP 8.3 and >=11? Or skip that 5.x? » 5.x requiring PHP 8.3 and >=10.2, 6.x requiring PHP 8.3 and >=11? Or skip that 5.x?
Issue summary: View changes
Related issues: +#3428342: Automated Drupal 11 compatibility fixes for cdn

News since last time:

  1. Drupal 11 requires PHP 8.3
  2. PHP 8.1 support has been extended to December 31, 2025: https://www.php.net/supported-versions.php

I wrote 2.5 months ago:

So the choices are:

  1. 5.x requiring PHP 8.2 and >=10.2, 6.x for >=11 requiring PHP 8.3
  2. 5.x requiring PHP 8.3 and >=11, no 6.x any time soon

I think there's a 3rd option:

  1. 5.x requiring PHP 8.3 and >=10.2, no 6.x any time soon

… that'll just mean that Tour support won't be available if you update to 5.x while still on Drupal 10.2.x But that's fine.

It'll still get us to where we need to be: a new major version that supports Drupal 11, will be around for the lifetime of Drupal 11, and is compatible with Drupal 10.x too (just not the first few minors).

Note that a 5.x version will be necessary anyway to support Drupal, see #3428342-5: Automated Drupal 11 compatibility fixes for cdn.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: 5.x requiring PHP 8.3 and >=10.2, 6.x requiring PHP 8.3 and >=11? Or skip that 5.x? » [meta] 5.x to require PHP 8.3 and >=10.2
Related issues: +#3444812: CdnIntegrationTest::testCss() fails on Drupal >=10.3 since #3432183

Per #4.

Especially now that tests are green for 4.x on 10.3, since #3444812: CdnIntegrationTest::testCss() fails on Drupal >=10.3 since #3432183.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 4.x-dev » 5.x-dev
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [meta] 5.x to require PHP 8.3 and >=10.2 » 5.x to require PHP 8.3 and >=10.2: bump requirements
Assigned: Unassigned » wim leers
Category: Plan » Task

The 5.x branch now exists. So let's bump the requirements here.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: 5.x to require PHP 8.3 and >=10.2: bump requirements » 5.x to require PHP 8.3 and >=10.3: bump requirements
Issue summary: View changes
Issue tags: -PHP 8.2

The FullyValidatable validation constraint only became available in Drupal 10.3, see https://www.drupal.org/node/3404425.

So, 5.x should require 10.3, not 10.2.

Wim Leers opened merge request !27

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: 5.x to require PHP 8.3 and >=10.3: bump requirements » 5.x to require PHP 8.3 and >=10.3: bump requirements + fix deprecations
Related issues: +#3427564: Require `langcode: …` only for simple config that contains translatable values

To get this MR to pass tests, this issue must also address all deprecations. For example: PHPUnit has become more strict, #3427564: Require `langcode: …` only for simple config that contains translatable values, and more.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Active » Reviewed & tested by the community

The two remaining PHPStan errors will be fixed by #3394172: Adopt Drupal core 10.3 config validation infrastructure 👍

  • Wim Leers committed ee09c208 on 5.x 
    Issue #3421351 by Wim Leers, Gábor Hojtsy: 5.x to require PHP 8.3 and >=...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.