Problem/Motivation

Php Inspections (EA Extended) reports:
Objects are always passed by reference; please correct '& $form_state'. in the FormAlterInterface.

Proposed resolution

Remove the &

CommentFileSizeAuthor
#2 FormAlterInterface-not-by-reference-3420012-1.patch751 bytesdahousecat

Comments

dahousecat created an issue. See original summary.

dahousecat’s picture

dahousecat commented
StatusFileSize
new FormAlterInterface-not-by-reference-3420012-1.patch751 bytes

  • dahousecat authored c1f6ff95 on 8.x-1.x 
    Issue #3420012 by dahousecat: Objects are always passed by reference;...
aronne’s picture

aronne commented
Status: Active » Fixed

Hi @dahousecat,
and thank you for you contribution.
Patch applied on the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

taraskorpach’s picture

taraskorpach
he/him
Location Lutsk 🇺🇦
commented

It would be helpful to add a message in the release notes about this change. I had to discover on my own why a significant part of my site was down after a simple update :)

aronne’s picture

aronne commented

Hi @taraskorpach,
I’m sorry to hear that. I thought linking the issue was enough but maybe you are right.

I’ll try to be more accurate next time.

Kind regards,
aronne