Problem/Motivation

With Drupal 10.2.2 (and possibly previous versions), the error $(...).once is not a function is thrown on pages containing a select_or_other widget

Proposed resolution

Replace jQuery.once with drupal/once in MultipleSelectStatesHack.js
@see https://www.drupal.org/node/3158256

Remaining tasks

CommentFileSizeAuthor
#9 replace_jquery_once_with_drupal_once-3418627-9.patch1.89 KBvensires
#7 replace_jquery_once_with_drupal_once-3418627-7.patch2.35 KBvensires
#5 3418627-select_or_other-drupal10_compatibility-5.patch1.76 KBbaikho
#4 compatibleDrupal10.patch3.61 KBlazzyvn

Issue fork select_or_other-3418627

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jofitz created an issue. See original summary.

jofitz opened merge request !12

jofitz’s picture

jofitz
he/him
commented
Version: 4.1.0 » 4.x-dev
Assigned: jofitz » Unassigned
Issue summary: View changes
Status: Active » Needs review
lazzyvn’s picture

lazzyvn commented
StatusFileSize
new compatibleDrupal10.patch3.61 KB

@jofitz
You didn't fix it well at all. It must be added once to the library. in js it has to import once. and it must use $().each and not once.forEach, because it uses $(this). Remove your merge request and fixed with my patch

baikho’s picture

baikho commented
StatusFileSize
new 3418627-select_or_other-drupal10_compatibility-5.patch1.76 KB

Couldn't apply patch from #4, so re-adding

vensires made their first commit to this issue’s fork.

vensires’s picture

vensires
Location Greece
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new replace_jquery_once_with_drupal_once-3418627-7.patch2.35 KB

Patch in #5 works great. I'm setting this as RTBC!

Extra things done:
- Updated the MR to match the changes from the patch
- Changed the info.yml file since according to the documentation the core/once is not available before 9.2.0; this means the new version won't support Drupal 8.8.

Also attaching patch from latest MR diff.

ivnish’s picture

ivnish
he/him
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
vensires’s picture

vensires
Location Greece
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new replace_jquery_once_with_drupal_once-3418627-9.patch1.89 KB

Resolved conflict and rerolled.
The conflict was related to the main module not supporting Drupal version 9 anymore. So it should normally be RTBC.

ivnish changed the visibility of the branch 3418627-replace-jquery.once to hidden.

  • ivnish committed c0d5eb86 on 4.x authored by jofitz 
    [#3418627] feat: Replace jQuery.once with drupal/once

By: jofitz
By:...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.