Problem/Motivation

At #3417482: [Meta] Pass Eslint validations we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the node_type_example sub-module

Initial errors detected by 27/01/2024

modules/node_type_example/config/install/core.entity_form_display.node.basic_content_type.default.yml
  24:28  error  Multiple spaces found before '}'  no-multi-spaces
  33:28  error  Multiple spaces found before '}'  no-multi-spaces
  37:16  error  Multiple spaces found before '}'  no-multi-spaces
  38:28  error  Multiple spaces found before '}'  no-multi-spaces
  44:28  error  Multiple spaces found before '}'  no-multi-spaces
  50:28  error  Multiple spaces found before '}'  no-multi-spaces
  54:16  error  Multiple spaces found before '}'  no-multi-spaces
  55:28  error  Multiple spaces found before '}'  no-multi-spaces
  63:28  error  Multiple spaces found before '}'  no-multi-spaces
  64:10  error  Multiple spaces found before '}'  no-multi-spaces
  65:24  error  Multiple spaces found before '}'  no-multi-spaces
modules/node_type_example/config/install/core.entity_form_display.node.locked_content_type.default.yml
  24:28  error  Multiple spaces found before '}'  no-multi-spaces
  33:28  error  Multiple spaces found before '}'  no-multi-spaces
  37:16  error  Multiple spaces found before '}'  no-multi-spaces
  38:28  error  Multiple spaces found before '}'  no-multi-spaces
  44:28  error  Multiple spaces found before '}'  no-multi-spaces
  50:28  error  Multiple spaces found before '}'  no-multi-spaces
  54:16  error  Multiple spaces found before '}'  no-multi-spaces
  55:28  error  Multiple spaces found before '}'  no-multi-spaces
  63:28  error  Multiple spaces found before '}'  no-multi-spaces
  64:10  error  Multiple spaces found before '}'  no-multi-spaces
  65:24  error  Multiple spaces found before '}'  no-multi-spaces
modules/node_type_example/config/install/core.entity_view_display.node.basic_content_type.default.yml
  22:16  error  Multiple spaces found before '}'  no-multi-spaces
  23:28  error  Multiple spaces found before '}'  no-multi-spaces
  26:10  error  Multiple spaces found before '}'  no-multi-spaces
modules/node_type_example/config/install/core.entity_view_display.node.locked_content_type.default.yml
  22:16  error  Multiple spaces found before '}'  no-multi-spaces
  23:28  error  Multiple spaces found before '}'  no-multi-spaces
  26:10  error  Multiple spaces found before '}'  no-multi-spaces
modules/node_type_example/config/install/field.field.node.basic_content_type.body.yml
  20:17  error  Multiple spaces found before '}'  no-multi-spaces
  24:24  error  Multiple spaces found before '}'  no-multi-spaces
modules/node_type_example/config/install/field.field.node.locked_content_type.body.yml
  20:17  error  Multiple spaces found before '}'  no-multi-spaces
  24:24  error  Multiple spaces found before '}'  no-multi-spaces
/modules/node_type_example/config/install/node.type.basic_content_type.yml
  14:24  error  Multiple spaces found before '}'  no-multi-spaces
modules/node_type_example/config/install/node.type.locked_content_type.yml
  14:24  error  Multiple spaces found before '}'  no-multi-spaces

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: node_type_example
  3. Fix the issues found and make a MR with the fixes.

Issue fork examples-3417507

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jlbellido created an issue. See original summary.

tyler36 made their first commit to this issue’s fork.

apaderno made their first commit to this issue’s fork.

avpaderno’s picture

Title: Pass Eslint validations: Node type example » Pass Eslint validations: Node Type Example
Status: Active » Needs review

  • apaderno committed 0b1f2efa on 4.0.x
    Issue #3417507: Fix the ESLint errors reported for the Node Type Example...
avpaderno’s picture

Title: Pass Eslint validations: Node Type Example » Pass ESLint validations: Node Type Example
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.