Problem/Motivation

Allow setting the Adobe Analytics metatag attributes data-gc-analytics-owner and data-gc-analytics-topic.

User interface changes

UI for these attributes appears in metatag module config.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#8 wxt-aa_attributes-3415924-8.patch1.84 KBliam morland
#7 wxt-aa_attributes-3415924-7.patch1.52 KBliam morland
#2 wxt-aa_attributes-3415924-2.patch7.79 KBliam morland

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
StatusFileSize
new wxt-aa_attributes-3415924-2.patch7.79 KB
sylus’s picture

sylus commented

This looks awesome!

Thanks @Liam for the improvement!

Committed and attributed!

Will add this functionality to the docsite.

  • Liam Morland authored 842778c1 on 5.2.x 
    Issue #3415924 by Liam Morland: Allow setting GC Adobe Analytics metatag...
sylus’s picture

sylus commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new wxt-aa_attributes-3415924-7.patch1.52 KB

Following client testing, it has been discovered that additional spaces are needed.

Update: The spaces may not be the problem, so don't commit this until we have verified that.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new wxt-aa_attributes-3415924-8.patch1.84 KB

It appears to be necessary to have exactly four levels. This patch pads empty levels with "N/A".

jwylarsen’s picture

jwylarsen commented

I don't see a meta element added to the page source when I provide a value in these fields. Am I doing something wrong?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

You need to visit admin/config/search/metatag, edit the tag type, scroll down to "Adobe Analytics", and put a token in the field.

jwylarsen’s picture

jwylarsen commented

Does it have to be a token? I tried putting in a literal string and don't see it in the head.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Check the code for details. I think it has to be a token for a field such as [node:field_fieldname].

jwylarsen’s picture

jwylarsen commented

Ahh, okay. I see that now, thanks.

joel_osc’s picture

joel_osc commented
Status: Closed (fixed) » Needs review

Hope I don't offend anyone for re-opening this... it seems there is a follow-up patch that is needed.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The patch in #8.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Hmmm, the patch in #8 seems to be in the 5.4.x branch - https://github.com/drupalwxt/wxt/blob/63cde06e8c52aa001284cb4ff8bf2e5c7a3f4a56/modules/custom/wxt_ext/wxt_ext_metatag/src/Plugin/metatag/Tag/AdobeAnalyticsAttributeBase.php#L109

Which branch are you seeing this issue in?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed

I noted it missing from 5.2.x and since I didn't see a linked commit, I supposed it had not been committed. I see it was added in commit ac03fc27. I wonder why it doesn't appear here. Anyway, it's fine. This issue can go back to "Closed (fixed)".

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.