Problem/Motivation

When viewing a node in Preview mode, the context does not include the route, so we have a cached version of the sidebar that applies for all routes, and since it's the preview it mean that the sidebar is never displayed.

Steps to reproduce

Create a node, preview it, and then save it. The action toolbar is not visible. Note that it is possible that this only happens for users with lower permissions, since the route dependency could come from somewhere else in the toolbar.

Proposed resolution

Add the route context for the preview as well.

Remaining tasks

Add test coverage.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3412248-2-test-fix.patch1.24 KBmathilde_dumond
#2 3412248-2-test-only.patch933 bytesmathilde_dumond

Issue fork moderation_sidebar-3412248

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mathilde_dumond created an issue. See original summary.

mathilde_dumond’s picture

mathilde_dumond commented
Status: Active » Needs review
StatusFileSize
new 3412248-2-test-only.patch933 bytes
new 3412248-2-test-fix.patch1.24 KB

Upload of a patch with only the test, and a patch with test + fix.

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !12

japerry made their first commit to this issue’s fork.

  • japerry committed 0a938e67 on 8.x-1.x 
    Issue #3412248 by mathilde_dumond: Cache information is missing in node...
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.