Problem/Motivation

  • Add a BDD test step to take a screenshot to come up with the UI design document (openstack_instance.edit, start)

Issue fork cloud-3410766

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !2186

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

sekinet’s picture

sekinet commented
Title: Add a BDD test step to take a screenshot to come up with the UI design document (openstack_instance.edit) » Add a BDD test step to take a screenshot to come up with the UI design document (openstack_instance.edit, start)
Issue summary: View changes

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the patch. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@sekinet

Can you please rebase the patch due to the previous merge? Thanks!

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your review. I have rebased the patch. Could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the patch. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 89830f43 on 6.x authored by sekinet 
    Issue #3410766 by sekinet, yas: Add a BDD test step to take a screenshot...

  • yas committed ffeec292 on 5.x authored by sekinet 
    Issue #3410766 by sekinet, yas: Add a BDD test step to take a screenshot...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.