Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Needs review » Needs work

Patch does not apply.

Its good to make the descriptions better.

esmerel’s picture

Status: Needs work » Closed (won't fix)

No updates after the needs work in more than 6 months

hass’s picture

Status: Closed (won't fix) » Needs work

How about re-roling? Issues are still inside

merlinofchaos’s picture

Status: Needs work » Closed (won't fix)

I see esmerel's name as a list of Views maintainers.

I do not see hass' name on the list of Views maintainers.

Please do not give us orders. If you want to reroll the patch, please do so, but issues that are 'needs work' for 6 months are still considered open and clearly nobody is doing the work.

hass’s picture

My patch has not committed after 10 months. No wonder that it fails.

merlinofchaos’s picture

I'd care, but since you've never lifted a finger to actually ease the burden of maintaining this issue queue, but instead have consistently added additional burden through being stubborn and combative, you should not be surprised that I don't jump up and down to review your patches.

hass’s picture

Status: Closed (won't fix) » Needs review
FileSize
254.58 KB
17.32 KB

Updated 2.x patch attached.

I tried to apply it to HEAD, but everytime the includes/admin.inc and handler/views_handler_filter.inc are completly deleted and recreated. I have no idea what's broken in HEAD. Also attached the 3.x patch. Keep in mind that the includes/admin.inc and handler/views_handler_filter.inc have no other changes than in 2.x, but eclipse made this big DIFFs and it's not in my hand... no idea why diff is not able to figure out only the changed lines in HEAD!???

dawehner’s picture

Status: Needs review » Needs work

The line endings of 3.x was changed. Please rerole a valid patch against 3.x

A valid patch means not 250 kb.

The problem with patched translations in 2.x cycle is that you might brake existing translations.

hass’s picture

Status: Needs work » Needs review
FileSize
18.14 KB

Ups, there is already a D7 version... above D6_views_translatable_ strings_3.x.patch was made against HEAD - is this D7?`

Attached is another patch for D6 3.x.

hass’s picture

@dereine: Yeah, you are right. HEAD contains files with CRLF and my patch fixes this bug by changing to LF only. I tried several sync's, but I'm still getting the buggy CRLF in two files from HEAD. Not my bug.

hass’s picture

The problem with patched translations in 2.x cycle is that you might brake existing translations.

We never cared about it yet as views has real usability/wording/UI issues and it's better to change than keep another year bad user experience. I have also fixed the German translation files after such changes asap.

dawehner’s picture

HEAD points afaik to an old 2.x version.

hass’s picture

Yeah I see, but HEAD contains buggy files with wrong line endings...

Here are new patches. For not confusing versions I'm re-attaching them again with correct naming. As HEAD is out of sync the HEAD patch is not attached.

merlinofchaos’s picture

-      '#title' => t('Require this relationship'),
+      '#title' => t('Relationship is required'),

Changing this from an active (the checkbox does something) to a passive (the checkbox is something) is not an improvement in English.

-        '#title' => t('Force single'),
+        '#title' => t('Force single option'),
         '#description' => t('Force this exposed filter to accept only one option.'),

Space here is pretty tight, I don't see value in adding the word 'option' there. Additionally, it appears in the description. If the title of the checkbox is going to be more than a word or two,t hen we should omit the description. However, 'force single option' is not enough more descriptive than 'force single' so the description is still necessary. Therefore, I don't like this change. The same is true for all of the filter checkbox changes in the patch.

-        $errors[] = t('Style @style requires a row style but the row plugin is invalid.', array('@style' => $this->definition['title']));
+        $errors[] = t('Style %style requires a row style, but the row plugin is invalid.', array('%style' => $this->definition['title']));

While the addition of the comma is valid here, English rules say that on short clauses the writer can omit it. I would rather not make this change and break the existing translations just to add a comma. I'm not particularly against the comma, mind, but just don't see the need to change it.

-            <?php print t('Path: !path', array('!path' => $view->path)); ?> <br />
+            <?php print t('Path: @path', array('@path' => $view->path)); ?> <br />

I'm not sure why you think this is valid, but that change actually breaks the UI.

-    'help' => t('The translation status of the node--whether or not the translation needs to be updated.'),
+    'help' => t('The translation status of the node - whether or not the translation needs to be updated.'),

In English the double dash without spaces is correct and the single dash with spaces is not.

-  alert(Drupal.t("An error occurred at @path.\n\nError Description: @error", {'@path': path, '@error': error_text}));
+  alert(Drupal.t("An error occurred at path @path.\n\nError Description: @error", {'@path': path, '@error': error_text}));

I don't feel that the addition of the word path is necessary here.

-            drupal_set_message(t('@type handler @table.@field is not available.', array(
-              '@type' => $info['stitle'],
-              '@table' => $handler->table,
-              '@field' => $handler->field,
+            drupal_set_message(t('%type handler %table.%field is not available.', array(
+              '%type' => $info['stitle'],
+              '%table' => $handler->table,
+              '%field' => $handler->field,

I don't feel like use of theme('placeholder') here is valuable.

-  $form['#title'] .= t('Configure @type', array('@type' => $types[$type]['ltitle']));
+  $form['#title'] .= t('Configure %type', array('%type' => $types[$type]['ltitle']));

The use of % is definitely not right here, it's not a proper name. It's supposed to form a sentence on its own.

-  $form['#title'] .= t('Rearrange @type', array('@type' => $types[$type]['ltitle']));
+  $form['#title'] .= t('Rearrange %type', array('%type' => $types[$type]['ltitle']));

Ditto. Skipping others like it.

dawehner’s picture

Status: Needs review » Needs work

So this needs work :)

MustangGB’s picture

Issue summary: View changes
Status: Needs work » Closed (won't fix)