Problem/Motivation

The locale deploy allows a site to manage all of its translation deployments via it's own project repository and prevent the translation system from getting translations from localize.drupal.org outside of its own Drush commands. One of the things it does is remove the version information from translation files. This results a warning in _install_prepare_import() due to assumptions that code makes.

Steps to reproduce

  1. Install minimal
  2. Enable locale_deploy module
  3. Add a language
  4. Run drush locale-deploy:localize-translations
  5. Import the site from configuration drush si --existing-config

Proposed resolution

There's nothing for this code to do in this situation.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#8 3406697-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3406697

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#3182660: [PP-1] Make translation filename pattern configurable during install

This is very related to #3182660: [PP-1] Make translation filename pattern configurable during install

alexpott opened merge request !5714

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks good :)

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

I'm triaging RTBC issues. I read the IS, the comments and the MR. I didn't find any unanswered questions.

I left suggestions in the MR for coding standards. Plus I think a comment is needed so I had a go at that, perhaps someone has a better one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community

I addressed @quietone's review. As the changes were minimal, setting back to rtbc.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3406697-nr-bot.txt90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community

Fixed merge conflict.

quietone’s picture

quietone commented
Assigned: Unassigned » quietone

Assigning to myself to commit tomorrow

  • quietone committed 220f04c2 on 11.x 
    Issue #3406697 by alexpott, chr.fritsch: Fix notice in...

  • quietone committed 011f36a8 on 10.2.x 
    Issue #3406697 by alexpott, chr.fritsch: Fix notice in...
quietone’s picture

quietone commented
Assigned: quietone » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed 220f04c and pushed to 11.x and 011f36a and pushed to 10.2.x. Thanks!

quietone closed merge request !5714

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.