Comments not working, editing inaccuracies [#340269]

Hi, The comments display:

[comment_author:user-name-url] replied on [node:title-link]. Rather than doing the replacements correctly.

Also when editing a page, the editor isn't used as the username, but the node poster instead. This causes confusion on wiki pages.

Thanks.

Comments

Comment #1

Flying Drupalist CreditAttribution: Flying Drupalist commented 28 November 2008 at 16:44

Priority:

Normal

» Critical

Comment #2

Stalski CreditAttribution: Stalski commented 28 November 2008 at 18:57

Assigned:	Unassigned	» Stalski
Status:	Active	» Postponed (maintainer needs more info)

Good point

"[comment_author:user-name-url] replied on [node:title-link]." is not a usable variables replacement anymore. Now you have to use !variable to substitute things.

For the problem itself, comment_author is not necessarily the node author, and when changing a page with the admin account will mean that the original author (maybe not admin) has updated his content.
This is indeed a good remark and is not a bug in fact. I don't know what to do with this. Both seem logical in some cases.
You could even say "when updating node content with a admin account or a webmaster role, i don't want to see the updates at all". Suppose a webmaster role just replaced a word in the content because he feels that does not fit on the site. Hmmm something to keep think about.
Something that makes sense too , is to have options to set this behavior on a administer settings page.

Please let me know how you feel on this subject? In general, i go along with you and think the most logical thing to do, is use the current logged in user as "editor" or "modifying other".

thx

Comment #3

Flying Drupalist CreditAttribution: Flying Drupalist commented 28 November 2008 at 19:24

Hi, I don't understand your reply perfectly, and I think maybe my original post wasn't very clear.

Ugh, why did I do this. I combined two seperate issues into one thread, actually these are two different topics. The first bug is:

1. The comments display in the messages as: [comment_author:user-name-url] replied on [node:title-link]. In the message settings I see them being set to: !username_link replied on !node_title_link. and !username_link replied %number% times on !node_title_link.

I'm not sure what's going on with the comments, but comment messages are not working for me.

2. The second issue that's perhaps not a bug, is that the editor is always set as the node author, which I feel should be set as logged in user. I can't think of a case when I would want the editor to be the node author if it wasn't, and in fact for my wiki content types it's necessary to have it be set as the user doing the actual editing.

Excluding admins wouldn't be a feature I would use, as I would want admin updates to show as messages. But maybe somebody would find a usecase for it. Right now as far as this goes, I would just like to see the update messages reflect the actual updater.

My bad on this one, the two issues aren't related.

Thanks again for making this module and your support.