Problem/Motivation

While adding phpstan to preview_link, it was complaining about
Access to an undefined property Drupal\dynamic_entity_reference\Plugin\Field\FieldType\DynamicEntityReferenceItem::$target_type

This is because we don't have $ infront of all the properties.

Issue fork dynamic_entity_reference-3400702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !16

acbramley’s picture

acbramley commented
Status: Active » Needs review
acbramley’s picture

acbramley commented

Ignore 3.x branch, accidentally committed to it in the MR fork.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Hehe, tbh, this was added before PHPStan started supporting it. :D

  • jibran committed e77ef625 on 3.x 
    Issue #3400702 by acbramley, jibran: DynamicEntityReferenceItem @...

  • jibran committed e927e0e3 on 4.x 
    Issue #3400702 by acbramley, jibran: DynamicEntityReferenceItem @...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 4.x and 3.x. Thank you.

jibran closed merge request !16

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.