I have a markup field which I'm using to generate a value from php (as far as I know one can't use php in any other of weform's fields). I have checked the 'Include in e-mails' box under advanced settings for this field, but it does not appear in the email that gets sent to me.

Is this a bug, or desired behaviour? Could it be because I am using the form with the 'node as a block' module?

www.parkroad.co.za

CommentFileSizeAuthor
#3 webform-5.x-2.3-hide_markup_send_to_email_checkbox-339700-3.patch667 bytesfoxtrotcharlie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

The "Include in e-mails" box should not be an option for markup components as they shouldn't be included in e-mails by design. If you need to create custom code within an e-mail, you should theme the e-mail that is sent. So this is a bug, in that we need to remove that checkbox, since it doesn't have any effect.

foxtrotcharlie’s picture

foxtrotcharlie CreditAttribution: foxtrotcharlie commented
Assigned: Unassigned » foxtrotcharlie

Thanks quicksketch. I'll look into creating a patch for this.

foxtrotcharlie’s picture

foxtrotcharlie CreditAttribution: foxtrotcharlie commented
Component: Documentation » Code
Status: Active » Needs review
FileSize
webform-5.x-2.3-hide_markup_send_to_email_checkbox-339700-3.patch667 bytes

Attached patch to not display the "Include in e-mails" checkbox for the webform markup field component. Markup field should not be included in e-mails by design. Patch prevents the component type 'markup' from displaying this checkbox in a similar manner to the way that the pagebreak and fieldset components are excluded.

This is a patch for webform module 5.x-2.3. For 6.x-2.3 patch, see this node: http://drupal.org/node/341456

foxtrotcharlie’s picture

foxtrotcharlie CreditAttribution: foxtrotcharlie commented
Assigned: foxtrotcharlie » Unassigned

Changed to unassigned. For some reason I assigned it to myself, but I can't review my own patch.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed

Thanks foxtrotcharlie! I much appreciate the patches! I committed to both Drupal 5 and 6.

foxtrotcharlie’s picture

foxtrotcharlie CreditAttribution: foxtrotcharlie commented

Absolute pleasure - was my first patch ever so I'm really stoked!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Title: Webform markup field not appearing in email » Remove Nonfunctional "E-mail" Checkbox from Markup Components

Slightly better title for the 2.4 release.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented

Is there any documentation on how to theme an email Webform sends out? I've had some trouble with figuring this out...

czeky’s picture

czeky CreditAttribution: czeky commented

webform_components.inc,v 1.1.2.44 2009/11/06 00:25:46

hi, got this version, seems it's already in the code, but I cant get markup in email, no select box appears (other components are okay and have "E-mail" select box visible, I would really like to have possibility to output markup in email

thanx a lot, so much use of this module!