Problem/Motivation

Warning in the logs

Deprecated function: Creation of dynamic property Drupal\open_readspeaker\Plugin\Block\OpenReadspeakerBlock::$request is deprecated in Drupal\open_readspeaker\Plugin\Block\OpenReadspeakerBlock->__construct() (regel 53 van /app/web/modules/contrib/open_readspeaker/src/Plugin/Block/OpenReadspeakerBlock.php)

Steps to reproduce

Install un D10.1 with php8.2

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 open_readspeaker-php8.2-deprecations-3384235-2.patch555 bytesfeng-shui

Issue fork open_readspeaker-3384235

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

parijke created an issue. See original summary.

feng-shui’s picture

feng-shui commented
StatusFileSize
new open_readspeaker-php8.2-deprecations-3384235-2.patch555 bytes

Patch attached to fix the deprecation.

sunlix made their first commit to this issue’s fork.

sunlix opened merge request !25

  • sunlix committed 22ca1036 on 2.x 
    Fix #3384235: deprecation dynamic property
sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Status: Active » Fixed

Thanks guys. I have rearranged the dependency injection to not have instantiation in the constructor.
But the initial patch had solved this too :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan’s picture

mstrelan commented

This was only committed to 2.x, should it be backported to 8.x-1.x?

wylbur’s picture

wylbur commented
Issue tags: +PHP 8.2

There is another ticket open covering this for the 8.x-1.0 branch - which is the recommended version!
https://www.drupal.org/project/open_readspeaker/issues/3413732