Problem/Motivation

FILE: /var/www/html/web/modules/contrib/audio_embed_field-3379962/src/Plugin/Field/FieldWidget/AudioTextfield.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
29 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork audio_embed_field-3379962

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Nishant created an issue. See original summary.

kpoornima made their first commit to this issue’s fork.

kpoornima’s picture

kpoornima commented
Assigned: nishant » kpoornima

I am looking on it

nishant’s picture

nishant
Primary language English
commented
Issue summary: View changes

kpoornima opened merge request !3

kpoornima’s picture

kpoornima commented
Assigned: kpoornima » Unassigned
Status: Needs work » Needs review

Please review and Merge

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Needs work

Hi @kpoornima,

When I applied your MR !3 to the Audio Embed Field module against 8.x-2.x-dev on Drupal 9.5.10, it didn't resolve all the errors.
See the remaining 1 error below:

FILE: /.../audio_embed_field/modules/audio_embed_media/audio_embed_media.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
--------------------------------------------------------------------------------------------------------------------------------------------------

Time: 473ms; Memory: 10MB

Please run this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig audio_embed_field

Moving this to Needs work for now.

Thank you!

kpoornima’s picture

kpoornima commented
Version: 8.x-2.x-dev » 8.x-2.0
kpoornima’s picture

kpoornima commented

HI @roberttabigue

MR !3 Phpcs errors checked with 8.x-2.0 and updated ticket version with 8.x-2.0.

Thanks You!

shashank5563’s picture

shashank5563 commented
Status: Needs work » Fixed
shashank5563’s picture

shashank5563 commented
Status: Fixed » Closed (fixed)