This changes only one line in taxonomy.module

It sets a title for the last menu item in the breadcrumb.

Of course, the most people won't matter, because they don't display the last (active) menu item in the breadcrumb. But some do...

The change is trivial, stable and conforms to all coding standards.

PS: $names[0] is always set at this point.

CommentFileSizeAuthor
#1 taxonomy_20.patch900 bytesdfg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dfg’s picture

dfg CreditAttribution: dfg commented
FileSize
taxonomy_20.patch900 bytes

the patch

Steve Dondley’s picture

Steve Dondley CreditAttribution: Steve Dondley commented

Can you please explain what the user will see differently with this patch applied? I installed the patch don't see anything different. I'm obviously one of the users that "display the last (active) menu item in the breadcrumb." How would I enable this?

dfg’s picture

dfg CreditAttribution: dfg commented

You cannot enable/disable that. I coded my own breadcrumb function (about 50 lines of code).

But that's not the problem. If you don't see something, this does not mean, that there was no failure...

As I said before, with this fix, the active menu item becomes a title in this case (all parent items already had one).

It's also a question of bad coding. And IT IS bad coding when you don't give the active menu item a TITLE.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Fixed

Committed to HEAD.

Jaza’s picture

Jaza CreditAttribution: Jaza commented
Status: Fixed » Reviewed & tested by the community

http://drupal.org/cvs?commit=36277 - a change was made to settings.php in this commit, which was clearly not meant to be committed. Please revert the settings.php change.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)