FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\file_browser\src\Plugin\Block\ImageEmbedBlock.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------
121 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
123 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
216 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
219 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | file_browser-33710580-5.patch | 6.51 KB | silvi.addweb |
| #2 | 3371058-2.patch | 2.58 KB | arti_parmar |
Comments
Comment #2
arti_parmar commentedKindly review patch.
Comment #3
ashutosh ahirwal commentedProvided patch in #2 applied cleanly but still there are error found by phpcs
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/file_browser
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/js/file_browser.view.js
-------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
70 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/file_browser.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/tests/src/Functional/InstallTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
20 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/file_browser.install
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\File\FileSystemInterface.
101 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
104 | WARNING | [ ] Unused variable $text.
123 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
223 | ERROR | [ ] The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
245 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/src/Plugin/views/field/FileBrowserPreview.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
72 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/src/Plugin/Block/ImageEmbedBlock.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Image\ImageFactory.
23 | ERROR | [x] Whitespace found at end of line
38 | ERROR | [ ] Parameter $entity_type_manager is not described in comment
86 | ERROR | [x] Use null coalesce operator instead of ternary operator.
189 | ERROR | [x] Use null coalesce operator instead of ternary operator.
270 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
Time: 299ms; Memory: 12MB
Comment #4
prabuela commentedComment #5
silvi.addweb commentedHello,
Created a patch based on comment #3. Please review.
Comment #6
cleavinjosh commentedHi @silvi.addweb,
I applied patch #5, it was applied smoothly and fixed some of the phpcs issues.
However, I still encountered some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.Thank you.
Comment #7
d.fisher commentedThese issues have been resolved on the 2.x branch. Thank you all for your contributions. Closing as fixed. Please upgrade to the 2.x release.
Comment #8
d.fisher commented