Problem/Motivation

Share OpenStack images in inter-regions (Add shared information to image tags) (Write)

Issue fork cloud-3366350

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !1835

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

sekinet’s picture

sekinet commented
Title: Share OpenStack images in inter-regions (Add shared information to image tags) (Write) » Share OpenStack images in inter regions (Add shared information to image tags) (Write)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Share OpenStack images in inter regions (Add shared information to image tags) (Write) » Add the function to share OpenStack images in inter regions (Add shared information to image tags) (Write)
Status: Needs review » Needs work

@sekinet

Thank you for the patch. It looks good; I posted my comments. Thanks!

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your comments. I fixed it, could you please check the patch?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

Thank you for the update. It looks good. Sorry, I have one more comment. Thanks

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your comment. Could you please check again?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

Thank you for the update. Based on your update, I posted my comments. Thanks!

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your comments. I fixed it, could you please review the patch?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 4479ab88 on 6.x authored by sekinet 
    Issue #3366350 by sekinet, yas: Add the function to share OpenStack...

  • yas committed c5292210 on 5.x authored by sekinet 
    Issue #3366350 by sekinet, yas: Add the function to share OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.