Closed (fixed)
Project:
PDF using mPDF
Version:
3.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 May 2023 at 13:16 UTC
Updated:
3 Jul 2025 at 14:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
abhinavk commentedI have created this patch to make this module Drupal 10 compatible.
Please review this patch.
Comment #3
rahul17 commentedApplied and tested patch #2 in Drupal 9.5.7 and 10.0.8. Patch applied cleanly and makes this module D10 compatible. Functionality is working fine.
Moving this to RTBC.
Comment #5
viniciusosouza commentedIn order this patch works we have to update the mpdf/mpdf library to ^8.0.0 to work with php ^8.0.
When we try to run composer require it breaks because the library is set to ^7.0.0 that requires php ^7.0.0.
Comment #6
b_sharpe commentedPatch for 2.x-dev which allows ^8.0.4
Comment #7
b_sharpe commentedSee note in #3331918: PDF using mPDF D10 compatibility? about how to make D10 compatible along with mpdf dependency
Comment #9
Kuriakose Kurian commentedI encountered issues with Drupal Version 9.5.11. The module version that I was able to patch is as follows:
Details on the errors I had to address, please refer to this screenshot: Link to Screenshot
I successfully resolved the issues with the following patch: Patch Link.
Comment #10
keshavv commentedThe patch https://www.drupal.org/files/issues/2023-10-17/pdf_using_mpdf_d10_compac... works perfectly. Thank you.
Comment #11
proweb.ua commentedCall to deprecated function render(): in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal\Core\Render\RendererInterface::render() instead.
/src/Controller/GeneratePdf.php
Comment #17
jan kellermann commentedI just opened a branch from 3.x and a MR and used the patch from this issue. There are some more problems to solve, so I change the state to work and assign to me.
I will add compatibility to 11.x also.
For existing system the patch is fine, but we will release to 3.x fpr D10/D11.
Comment #18
jan kellermann commentedComment #19
jan kellermann commentedThe MR passed the pipeline.
The MR delivers compatibility with D10 and D11.
I rewrote the part of delivering the PDF and am using Drupal's Response objects now. How about the caching?
Please have a quick review of eveything fits for your needs.
In the next step we will release a RC so that testing becomes easier and more people can participate.
Comment #20
jan kellermann commentedComment #21
jan kellermann commentedAdded title for D11
Comment #22
eyedrops commentedlooks good!
installed 3.x-D10 and it worked without problems. was able to generate pdf of the node as admin.
Comment #23
jan kellermann commentedThank you all for reporting, contributing and testing!
I merged this code and the code from #3475769 and #3520301 in this merge.
Please use the new alpha version of 3.x branch and give feedback.