In _imagecache_apply_action() the specific action is applied by using call_user_func() even though the actions expects the $image to be passed by reference. Is it the actions which are implemented wrong or the use of call_user_func instead of call_user_func_array?

I my case I have a crop action which depends on another preset modifying the $image object. This patch solves that.

Comments

drewish’s picture

if image is an object then it should be passed by reference right?

drewish’s picture

StatusFileSize
new1.46 KB

Why not just ignore the whole call_user_func() bit? We don't have a dynamic number of arguments. Objects are passed by reference implicitly.

drewish’s picture

Status:Needs review» Fixed
StatusFileSize
new1.41 KB

committed the attached to HEAD.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.