In _imagecache_apply_action() the specific action is applied by using call_user_func() even though the actions expects the $image to be passed by reference. Is it the actions which are implemented wrong or the use of call_user_func instead of call_user_func_array?

I my case I have a crop action which depends on another preset modifying the $image object. This patch solves that.

CommentFileSizeAuthor
#3 imagecache_335780.patch1.41 KBdrewish
#2 imagecache_335780.patch1.46 KBdrewish
call_user_func_reference.patch1.12 KBandershal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

drewish CreditAttribution: drewish commented

if image is an object then it should be passed by reference right?

drewish’s picture

drewish CreditAttribution: drewish commented
FileSize
imagecache_335780.patch1.46 KB

Why not just ignore the whole call_user_func() bit? We don't have a dynamic number of arguments. Objects are passed by reference implicitly.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs review » Fixed
FileSize
imagecache_335780.patch1.41 KB

committed the attached to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.