Problem/Motivation

_roleassign_get_assignable_roles() was changed to return the roles as key => label. However, \Drupal\roleassign\Plugin\views\field\RoleAssignUserBulkForm::init() uses in_array() which compares the rid with the role value.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 role-assign-bulk-actions-3353022-2.patch643 bytesberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new role-assign-bulk-actions-3353022-2.patch643 bytes

Looks like the bulk actions aren't tested?

  • nord102 committed bacc8ea1 on 2.0.x authored by Berdir 
    Issue #3353022 by Berdir: All role bulk actions hidden due to...
nord102’s picture

nord102
he/him
Primary language English
commented
Status: Needs review » Fixed

Thanks for the fix, looks like that was missed with the _roleassign_get_assignable_roles rework.

As for the Bulk Actions, it doesn't look like we currently have tests, but we should, that way it can catch things like this in the future. I'll make an new issue for that

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.