Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 portD9-D10-3351509-8.patch5.75 KBjorisclaes
#7 portD9-D10-3351509-7.patch5.74 KBakshay kashyap
#5 giving-erro.png161.75 KBakshay kashyap
#5 apply-patch.png26.61 KBakshay kashyap
#3 3351509.patch507 bytesranjit1032002

Issue fork zen-3351509

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bunty oberoi created an issue. See original summary.

Ranjit1032002 made their first commit to this issue’s fork.

ranjit1032002’s picture

ranjit1032002
Primary language English
Location India
commented
Status: Active » Needs review
StatusFileSize
new 3351509.patch507 bytes

Created a patch for Drupal 10 compatibility fixes, please review.
Thank You.

akshay kashyap’s picture

akshay kashyap commented
Assigned: Unassigned » akshay kashyap
akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new apply-patch.png26.61 KB
new giving-erro.png161.75 KB

Hi @Ranjit1032002,

Thanks for the Work.

Verified and tested patch #3 on Drupal 10.1.x Applied cleanly, but it gives errors. I have attached a screenshot for reference Please check.

Testing result:
Zen Theme is not compatible with Drupal 10.1.x

akshay kashyap’s picture

akshay kashyap commented
Status: Needs review » Needs work
akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new portD9-D10-3351509-7.patch5.74 KB

Created a Patch please review it.

akshay kashyap’s picture

akshay kashyap commented
Status: Needs work » Needs review
bunty oberoi’s picture

bunty oberoi
Location Dharamshala
commented
Assigned: akshay kashyap » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi @Akshay,

Verified and tested Patch Comment #7 on Drupal 10.1.x Applied patch cleanly

oberoi@oberoi-H510M-S2:~/Documents/projects/drupal/themes/contrib/zen$ git apply -v portD9-D10-3351509-7.patch
Checking patch STARTERKIT/STARTERKIT.info.yml...
Checking patch STARTERKIT/templates/block/block--no-wrapper.html.twig...
Checking patch STARTERKIT/templates/content/node.html.twig...
Checking patch STARTERKIT/templates/layout/html.html.twig...
Checking patch STARTERKIT/templates/layout/region--footer.html.twig...
Checking patch STARTERKIT/templates/navigation/breadcrumb.html.twig...
Checking patch STARTERKIT/templates/navigation/links--node.html.twig...
Checking patch STARTERKIT/templates/navigation/menu-local-tasks.html.twig...
Checking patch zen.info.yml...
Checking patch zen.theme...
Applied patch STARTERKIT/STARTERKIT.info.yml cleanly.
Applied patch STARTERKIT/templates/block/block--no-wrapper.html.twig cleanly.
Applied patch STARTERKIT/templates/content/node.html.twig cleanly.
Applied patch STARTERKIT/templates/layout/html.html.twig cleanly.
Applied patch STARTERKIT/templates/layout/region--footer.html.twig cleanly.
Applied patch STARTERKIT/templates/navigation/breadcrumb.html.twig cleanly.
Applied patch STARTERKIT/templates/navigation/links--node.html.twig cleanly.
Applied patch STARTERKIT/templates/navigation/menu-local-tasks.html.twig cleanly.
Applied patch zen.info.yml cleanly.
Applied patch zen.theme cleanly.

Testing Steps:-
1. Install Drupal 10.1.x version.
2. git clone --branch '8.x-7.x' https://git.drupalcode.org/project/zen.git
2. Applied Patch #7 /projects/drupal/themes/contrib/zen
3. Checked the changes difference using git diff
4. Installed theme and set it as default.

Testing result:
zen Theme compatible with Drupal 10.1.x Moving the issue to RTBC

linhnm’s picture

linhnm commented

linhnm opened merge request !5

jorisclaes’s picture

jorisclaes commented
StatusFileSize
new portD9-D10-3351509-8.patch5.75 KB

In the .info file

core_version_requirement can not be used to specify compatibility for a specific version before 8.7.7

This is fixed in the included patch

bharat murari’s picture

bharat murari commented

Will there be a D10 version available?

bharat murari’s picture

bharat murari commented

The patches doesn't work and maintainers are not updating. Will Zen theme will be end of life?

phiscock’s picture

phiscock commented

Does anyone have any suggestions for an alternative base theme to Zen (with similar grids functionality) that is being supported for Drupal 10 onwards? I’d much prefer to keep using Zen but sadly that no longer seems to be an option?