Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
FILE: ...l/drupal_9.4/drupal/web/modules/contrib/mixpanel/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | )
--------------------------------------------------------------------------------
FILE: ...html/drupal_9.4/drupal/web/modules/contrib/mixpanel/src/MixpanelClient.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
39 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
Time: 1.81 secs; Memory: 10MB
| Comment | File | Size | Author |
|---|
Issue fork mixpanel-3344391
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
rohit rana commentedComment #3
darvanenThanks for starting this @Rohit Rana, however - I have implemented a personal policy of only providing credit for code standards updates to new contributers who have not already recieved a credit for code standards updates, so I will be removing credit from this issue.
Also, please do not open coding standards updates with a specific title for an individial problem. Open a single issue for ALL required code standards fixes unless the module is so gigantic that it becomes impossible to manage. I have changed this issue to that effect.
Finally, I would also like to point out that rather than blindly following the suggestion provided by phpcs regarding the @return value documentation, if there is nothing specific to write in said documentation, the return typehint should suffice and the doc-comment can be deleted which will also satisfy phpcs.
Comment #4
darvanenNow that GitLab CI is in place and it's standard practice for contrib modules to include PHPCS tests I'm retracting my credit policy. All normal credits will be applied for this issue.
Comment #6
darvanen