Problem/Motivation
Super short version: cweagans/composer-patches that we require is breaking DrupalCI and there's no way to add it to the allow list before DrupalCI does the composer install. For details, see #3307885: Customize DrupalCI config to allow running cweagans/composer-patches; fails otherwise
Steps to reproduce
Run DrupalCI, get Composer require error.
Proposed resolution
Re-assess which patches we need and whether a new version of a dependency can be required that includes those patches, eventually removing cweagans/composer-patches so that we can run DrupalCI.
Multiselect module
We currently require version 8.x-1.2 of this which is the latest of that branch; this doesn't contain the fixes we use patches for; the 2.x branch which (at time of writing) has a beta release does contain the fixes from the patches.
- #2852660: CSS need improvement, causes field following multiselect to wrap which is a duplicate of #2981851: Floats not cleared which is in the beta.
- #3130242: No schema for multiselect.settings is in the beta.
It doesn't look look like either issue is necessary for Config Enforce Devel to function, so we could expand the version constraint to add ^2.0 and remove the patches, and most or all users will get the newer version with the fixes while technically not breaking backwards compatibility with Drupal 8, which has been end of life for months now.
Configuration development module
This one is likely to be the blocker as it doesn't look like the maintainers are present much or at all going back two or three years. Neither of these are even merged, though there is recent activity:
- #3296836: Automated Drupal 10 compatibility fixes -
This is mostly done but some problems with Drupal core version constraints at time of writing. We could go without it, but then we would't be able to support Drupal 10.0 anymore until it's merged.Update: has been merged. - #3163349: Define hooks to provide 'auto_import' and 'auto_export' - This is one is necessary for Config Enforce Devel to function. We should contribute to cleaning up the code in this issue and add some tests for the hooks.
We'll probably have to reach out the maintainers of the module to get these issues looked at once they're ready. We could also ask to be added as maintainers if they don't have time, maybe just temporarily to get these done and released, and then they can remove us as maintainers unless one or more of us have the bandwidth to help out in their issue queue.
Remaining tasks
Do the things.
User interface changes
Minimal or none, depending on Multiselect.
API changes
None?
Data model changes
None?
Issue fork config_enforce_devel-3343504
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3343504-remove-merged-config-devel-d10-patch
changes, plain diff MR !16
Comments
Comment #2
ambient.impactPostponing in light of #3307885: Customize DrupalCI config to allow running cweagans/composer-patches; fails otherwise being fixed.
Comment #6
spidermanI was finding a fresh build failing due to the D10 compatibility fix no longer applying, so I've pushed a commit on `1.0.x` to remove it. We may want to roll a new release on this basis, just to avoid composer failures downstream of us.
Comment #8
spiderman@raystuart Thanks for the MR! I'm sorry I didn't recognize your patch was the same as what I was doing, or I would have just merged that. In any case, we ended up in the same place. Appreciate your input :)
Comment #9
raystuart commentedOh, no worries @spiderman , it was easy to miss. I figured you probably committed and then remembered that this issue even exists.
Comment #10
ambient.impactMarking as fixed; see the attached related issues.