Fix the issues reported by phpcs [#3342224]

Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/views_remote_data/tests/modules/views_remote_data_pokeapi/config/install/core.entity_view_display.node.pokemon.teaser.yml
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
35 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/modules/views_remote_data_pokeapi/config/install/core.entity_view_display.node.pokemon.default.yml
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
34 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/modules/views_remote_data_pokeapi/README.md
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 119 characters
6 | WARNING | Line exceeds 80 characters; contains 119 characters
11 | WARNING | Line exceeds 80 characters; contains 111 characters
16 | WARNING | Line exceeds 80 characters; contains 89 characters
-------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Plugin/views/sort/PropertySortTest.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] Expected 1 blank line before function; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Plugin/views/argument/PropertyArgumentTest.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] Expected 1 blank line before function; 0 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Plugin/views/ViewsPluginTestBase.php
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
27 | ERROR | [x] Expected 1 blank line before function; 0 found
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Plugin/views/field/PropertyFieldTest.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] Expected 1 blank line before function; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Plugin/views/filter/PropertyFilterTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] Expected 1 blank line before function; 0 found
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Plugin/views/query/RemoteDataQueryTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Expected 1 blank line before function; 0 found
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Events/RemoteDataQueryEventTest.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/tests/src/Kernel/Events/RemoteDataLoadEntitiesEventTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
26 | ERROR | [x] Expected 1 blank line before function; 0 found
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_remote_data/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 119 characters
----------------------------------------------------------------------

Time: 10.38 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/views_remote_data/

Proposed resolution

Above error/warnings need to be fixed.

Comment	File	Size	Author
#10	after patch.png	128.31 KB	paraderojether
#10	before patch.png	193.43 KB	paraderojether
#4	Screenshot 2023-02-16 at 10.47.41 AM.png	133.44 KB	spriya2896
#2	3342224-2.patch	7.18 KB	samitk

Issue fork views_remote_data-3342224

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3342224-fix-the-issues changes, plain diff MR !20
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

16 February 2023 at 04:22

samit.310@gmail.com created an issue. See original summary.

Comment #2

samitk commented 16 February 2023 at 04:23

Assigned:	samitk	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	3342224-2.patch	7.18 KB

Above error/warnings are fixed.

Comment #3

spriya2896 commented 16 February 2023 at 04:29

Assigned:

Unassigned

» spriya2896

I will test this patch.

Comment #4

spriya2896 commented 16 February 2023 at 05:23

Status	File	Size
new	Screenshot 2023-02-16 at 10.47.41 AM.png	133.44 KB

I have tested this patch. This patch was applied successfully and shows no phpcs errors.

Comment #5

spriya2896 commented 16 February 2023 at 05:23

Assigned:	spriya2896	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Comment #6

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 16 February 2023 at 14:29

Title:	Drupal Coding Standards Issues \| phpcs	» Fix the issues reported by phpcs
Issue tags:	-, -

Comment #7

28 February 2023 at 15:17

urvashi_vora made their first commit to this issue’s fork.

Comment #8

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 28 February 2023 at 18:12

Priority:

Normal

» Minor

Comment #9

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 1 May 2023 at 20:08

Status:

Reviewed & tested by the community

» Needs review

It would be better that the patch is reviewed by somebody who does not work on the same organization.

Comment #10

paraderojether commented 2 May 2023 at 01:35

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	before patch.png	193.43 KB
new	after patch.png	128.31 KB

I reviewed patch #2, and verified it fixes the issues reported by the phpcs. Drupal core version 9.5.8, and Views Remote Data 1.0.X-dev.

I added screenshots for reference.
Thank You.

Reviewed & tested by the community

» Needs review

Comment #14

ankitv18 commented 24 June 2024 at 16:15

@mglaman please review the MR!20

Comment #15

clarkssquared commented 21 July 2024 at 14:26

Status:

Needs review

» Needs work

I applied the updated MR !20 after commit #14 and I can still see many PHPCS issues:

➜  views_remote_data git:(1.0.x) curl https://git.drupalcode.org/project/views_remote_data/-/merge_requests/20.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6783    0  6783    0     0  13277      0 --:--:-- --:--:-- --:--:-- 13647
patching file 'tests/src/Kernel/Events/RemoteDataQueryEventTest.php'
patching file 'tests/src/Kernel/Plugin/views/ViewsPluginTestBase.php'
patching file 'tests/src/Kernel/Plugin/views/argument/PropertyArgumentTest.php'
patching file 'tests/src/Kernel/Plugin/views/field/PropertyFieldTest.php'
patching file 'tests/src/Kernel/Plugin/views/filter/PropertyFilterTest.php'
patching file 'tests/src/Kernel/Plugin/views/query/RemoteDataQueryTest.php'
patching file 'tests/src/Kernel/Plugin/views/sort/PropertySortTest.php'
➜  views_remote_data git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_remote_data 

FILE: ...ta_pokeapi/config/install/core.entity_view_display.node.pokemon.teaser.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 35 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...a_pokeapi/config/install/core.entity_view_display.node.pokemon.default.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 34 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ontrib/views_remote_data/tests/modules/views_remote_data_pokeapi/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  5 | WARNING | Line exceeds 80 characters; contains 119 characters
  6 | WARNING | Line exceeds 80 characters; contains 119 characters
 11 | WARNING | Line exceeds 80 characters; contains 111 characters
 16 | WARNING | Line exceeds 80 characters; contains 89 characters
--------------------------------------------------------------------------------


FILE: ...ws_remote_data/tests/src/Kernel/Events/RemoteDataLoadEntitiesEventTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  8 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Component\Serialization\Json.
 26 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../Projects/d10/drupal_local/web/modules/contrib/views_remote_data/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 119 characters
--------------------------------------------------------------------------------

Time: 754ms; Memory: 12MB

➜  contrib git:(main) ✗

Comment #16

ankitv18 commented 21 July 2024 at 16:43

Status:

Needs work

» Needs review

Rebased and made minor changes to make pipelines green for all.

Comment #17

mglaman

English

WI, USA

commented 22 July 2024 at 15:05

Status:

Needs review

» Reviewed & tested by the community

Comment #18

mglaman

English

WI, USA

commented 22 July 2024 at 15:05

Comment #19

22 July 2024 at 15:06

mglaman committed 9249a485 on 1.0.x authored by ankitv18

Issue #3342224 by ankitv18, samit.310@gmail.com, urvashi_vora,...

Comment #20

mglaman

English

WI, USA

commented 22 July 2024 at 15:06

Status:

Reviewed & tested by the community

» Fixed

Comment #21

5 August 2024 at 15:09

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Issue fork views_remote_data-3342224

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Referenced by

News items

Our community

Documentation

Drupal code base

Governance of community