Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The generated cookie_domain in bootstrap.inc, conf_init() is not yet properly tested. This adds some tests for them in bootstrap.test.
Two notes:
- I had to resort to
$GLOBALS['cookie_domain']
instead ofglobal $cookie_domain
due to some unexpected behaviour. - There is a bug with the commented domains:
// 'www2.drupal.org' => '.drupal.org', // 'app.testing.drupal.org' => '.testing.drupal.org', // 'dev.drupal.co.uk' => '.drupal.co.uk', // 'app.dev.drupal.co.uk' => '.dev.drupal.co.uk',
but i will open a separate issue once this test is added. Can we leave them in the patch here in the meantime?
Hopefully it is ok to put it under "Testing Party 08"...
Comment | File | Size | Author |
---|---|---|---|
#5 | bootstrap.test-333587-5.diff | 3.76 KB | arjenk |
bootstrap.test_cookie_domain.patch | 3.58 KB | arjenk | |
Comments
Comment #1
arjenk CreditAttribution: arjenk commentedComment #3
lilou CreditAttribution: lilou commentedSee: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476
Comment #4
catchLooks good, but it should use example.com, and the assertions need meaningful messages as the last argument to show in the testing UI what was asserted.
Comment #5
arjenk CreditAttribution: arjenk commentedThe assertions give now more interesting info, and we now use example.com.
Comment #6
catchThe whitespace is off in the $cookie_domain_test_cases array, and there's also some stuff commented out in there - which should either be uncommented or removed.
Comment #7
catchMoving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.