Expanding json to include status error messages

+++ b/src/Controller/StatusDashboardClientController.php	(date 1673514953284)
@@ -91,6 +112,17 @@
+    foreach ($raw as $line) {
+      if (isset($line['severity']) && $line['severity'] > 1) {
+        $error_counter++;
+        break;
+      }
+    }

Is this correct? This would mean that the foreach stops after the first occurrence if I'm not mistaken. I think you want to remove the break or replace it with continue. And we only want errors larger as severity 1?

I guess it would also help to add a comment somewhere indicating what error corresponds to severity 1 or higher.

1. +++ b/src/Controller/StatusDashboardClientController.php	(date 1673520108051)
   @@ -91,6 +112,17 @@
   +      //By default only errors (severity > 1) will trigger. Severity > 0 to tirgger both errors or warnings. ¶
   

   Small nit, but the comment does not follow the coding standards (there is a typo, a trailing space and it's too long). It should be something like this:

   // By default only errors (severity > 1) will trigger.
   // Severity > 0 to tigger both errors or warnings.

2. +++ b/src/Controller/StatusDashboardClientController.php	(date 1673520108051)
   @@ -98,7 +130,8 @@
   +      'total_status_errors' => $error_counter
   

   Should have a trailing "," since it's an array and maybe the name "total_status_errors" would be better like "status_error_count" (singular) or simply "error_count".

It's okay if you don't want to fix this, I can do it when I commit it to the dev branch.

One additional question. Is there also a change needed on the "status_dashboard" module itself to show the added field? (I didn't dive into the code of that module yet as I only recently became a maintainer)

Sure no problem :-) glad to help you make your first code contribution and help steer you in the right direction.

I think the patch looks good now. One minor nit but I won't bother you with that ;-) looking forward to your next issue on the dashboard module itself.

Extra tip for you, the old patch flow (.patch files) will be deprecated in the future in favour of GitLab merge requests and issue forks :-) you can read about that here if you like: https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... feel free to use that on your next issue! The first time doing this might look complicated, but it's actually very easy to use.

I've made a new patch for the last dev version (1 Feb), because the last patch didn't apply.

Hi, I'll try to get this committed somewhere this week!

Perfect, thanks!

At the patch from https://www.drupal.org/project/status_dashboard_client/issues/3332883#co...
a comma was missing after $container->get('request_stack')

     return new static(
       $container->get('extension.list.module'),
       $container->get('datetime.time'),
       $container->get('request_stack')
+      $container->get('renderer'),
+      $container->get('system.manager')
     );

Also I added some code style fixes.