Problem/Motivation

Under PHP 8.2, there are a lot of messages like Creation of dynamic property ... is deprecated. For example, see these test results from Election.

Proposed resolution

Enabled PHP 8.2 testing in Views. Declare all the properties used or mark each class with #[\AllowDynamicProperties].

CommentFileSizeAuthor
#9 date7x3x-php82-3328051-09.patch1.68 KBjoseph.olstad
#7 date7x2x-php82-3328051-07.patch1.68 KBjoseph.olstad
#3 php82-3328051-03.patch492 bytesjoseph.olstad
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

ya just hit this now

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
php82-3328051-03.patch492 bytes

see patch

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

this patch seems to fix the problem

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
date7x2x-php82-3328051-07.patch1.68 KB

New patch, this time for 7.x-2.x

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-3.x-dev » 7.x-2.x-dev
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
date7x3x-php82-3328051-09.patch1.68 KB

now for 7.x-3.x

Ooops accidentally triggered 7.x-2.x, this patch is for 7.x-3.x, results are great!

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Related issues: +#3301821: Fix PHP 8.1 compatibility issues
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Reviewed & tested by the community

RTBC both of these patches, one for 7.x-2.x, the other for 7.x-3.x

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3301877: Plan for Date 7.x-2.14

Committed. Thank you.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland as a volunteer and at Scouting Waterloo Region commented

Thanks. It would be great to also enable testing of 7.x-3.x on PHP 8.2 (and while you're at it, for other databases too).

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Good idea. Done.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Thanks @DamienMckenna and @Liam Morland

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

@DamienMcKenna, a new 7.x-2.x-dev build of the migrate module was just pushed out, if someone re-triggered the date tests, PHP 8.2 and PHP 8.1 should now be 100% passing, if no one with maintainer access retriggers then I guess we just wait until the next commit triggers a new test

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

I just re-started the 8.2 tests, waiting to see how they go. If all goes well I'll make 8.2 the default for tests.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

PHP 8.2 all green, great!!! :) Thanks @DamienMcKenna

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.