Update CSS coding standards to include PostCSS and Drupal 10

+1 to this change! I think it's really needed so core can use modern CSS.

Yeah , i also agree with @cKrina with you it's need more CSS

Can you outline how these changes related to the existing CSS standard pages on d.o? Are there changes in the doc a complete replacement or replacing sections or new additions?

+1 on the need to update the standards. I think the doc was written as a full re-write of the standards, but I think there might be some things worth saving from the existing standards. For example, the "what to look for when reviewing CSS" is probably still worth keeping.

Update the Issue Summary to include links to the current pages.

It may be helpful to state what is to happen to those pages. Is the format of https://docs.google.com/document/d/1rihTDDGy9-m0TGIadgz16TQ1aONc0OC3u2TkJ8bNaxg/edit related to the pages that will be created/edited? As in, would a 'Heading 2' correspond to a Drupal wiki page?

Not sure if it's in the scope, but can the standard also include a commitment to review every X years?

Drupal is a PHP framework and requires regular updates to PHP for security and stability.
CSS is constantly eveolving depending on current browser market and trends.

I think we to set a formal timeline for re-evaluating supported browsers, build processes and best practises to prevent CSS standards from becoming "woefully outdated" again.

I would suggest every 4 years, perhaps aligned with every even (or odd) major Drupal release.

This reads as a reasonable change for the css docs. Only one thing I kinda miss in "Format Class Names using BEM". Can we have a state for the button also so we also show a state class structure? I understand there is a paragraph under St that regarding js state changes but shouldn't state also be shown if we are showing the other bem structures?

Perhaps a --primary state or --disabled?

This could be a Followup though to change. It's pretty minor.

I would suggest every 4 years, perhaps aligned with every even (or odd) major Drupal release.

I do support regular review of any policy but it is not something built into the existing practices. For myself, it is a long term plan.

This was discussed #3375432: Coding Standards Meeting 2023-08-15 and there was no objection to proceeding. So that step is done.

No, it hasn't been brought up at a core meeting. The next on is early next month. I have left a note in committer Slack for it to be added to the agenda.

I am updating this to the new process.

The first thing is to set this to RTBC and remove the 'final discussion tag'. This now puts us at Step 6. But since core is affected that moves to step 7, where this needs to go to a committer meeting. It was scheduled to be added to the latest core meeting but instead the issue for updating the process was discussed. I have now re-added that to the schedule.

As for the change record, that should be in this project. I am adding the tag for the change record.

Thanks for you patience!

There are open threads in the Google doc

It would be good to resolve them

For the record I'm in support of the changes

Gonna set rtbc, and suggest it will be added to core meeting.

We doel still need a change record it seems though. Quietone did point at the correct project in #16

Change record can be found here: #3406417: Major update to CSS coding standards to include PostCSS and Drupal 10.

@mherchel there seems to be one line not removed from the document yet, a placeholder for example code, which seems to have examples right above it? Quite minimal imo, so not gonna remove rtbc.

This was discussed at core committers meeting on Wed December 5th (UTC)
There were no objections

There was however a desire to split the tooling (e.g. stylelint) from the standard.

Can we review the document and remove any specific mentions of a particular tooling.

This will make it easier to change tooling without needing to change the standard.

I think is ready for a draft blog post now.

Updated the IS for the full new process, so that we can see all steps 1-9.

Discussion post is published 11 Dec
coding-standards-proposals-for-final-discussion-on-2-january-2024
Removing the 'Needs announcement for final discussion' tag

This has been ready to go for a while - can someone do the honours of the actual documentation update so we can mark this fixed?

I updated CSS formatting guidelines by replacing content with what is in the google doc. That is available for review. Also, the text is using 'whitespace' which is not in American English dictionaries. Should it be changed to 'white space'?

https://github.com/prettier/stylelint-prettier

in core now. https://www.drupal.org/project/drupal/issues/3409048

This still needs documentation updates.

Let's try a change of status.
This does need work but we need support from someone familiar with the new CSS standards.

Converted the google doc to 4 pages in the CSS section and removed the existing pages.

To:

Copy the gists instead of linking to external sources.
Remove postCSS, as catch pointed in the doc, this is not a section that need CS Committee approval for changes.

@mherchel, thank you.

Reviewing this again I found that the following needs to be done.

1. This isn't passing cspell checks, so that needs to be addressed.
2. The google doc has a comment from catch that the PostCSS section should not be in the coding standards because it is about tooling. This is not something that should go through the coding standards process to be changed. So, the title here isn't quite right, I think.
3. There are also references to Drupal 10 and Drupal 8, which should be checked and likely changed. The standards are for currently supported versions of Drupal.

Where to move the PostCSS page? Maybe development tools?