Update tabbable js to 6.0.1

This fixes an issue that will crash tabbable when interacting with scoped table headers.

https://github.com/focus-trap/tabbable/commit/0aab1e3f073c2a7e994b2f66b1...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dk-massive created an issue. See original summary.

dk-massive’s picture

dk-massive’s picture

Status: Active » Needs review
longwave’s picture

Status: Needs review » Needs work
Parent issue: » #3258933: [meta] Update JavaScript dependencies for Drupal 10

Thanks for opening this issue. This also needs the version changing in core.libraries.yml and yarn.lock.

The correct procedure is:

cd core
yarn upgrade tabbable
yarn vendor-update
longwave’s picture

Issue tags: +Drupal 10 rc blocker
andypost’s picture

Status: Needs work » Needs review
FileSize
67.64 KB

Fixed patch

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed 23b5cea on 10.0.x
    Issue #3320370 by dk-massive, andypost, longwave: Update to tabbable v6....
  • catch committed 17a5d8f on 10.1.x
    Issue #3320370 by dk-massive, andypost, longwave: Update to tabbable v6....
catch’s picture

Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Do we need a 9.5.x patch here too?

longwave’s picture

Version: 9.5.x-dev » 10.0.x-dev
Status: Patch (to be ported) » Fixed
Issue tags: -Drupal 10 rc blocker

9.5.x currently ships with tabbable 5.3.3, which is the latest release on the 5.x branch, and 6.0.0 drops support for IE11, so 9.5.x will have to remain on 5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.