Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When we moved to PHPStan level 1 the baseline in 10.0.x and 10.1.x became different. Let's make them the same to make our lives simpler.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#2 | 3320025-2.patch | 9.39 KB | alexpott |
| |||
#2 | 3320025-10.0.x-2.patch | 2.63 KB | alexpott |
|
Comments
Comment #2
alexpottNote that this fixes a bug in the way the deprecate dance was done in #1014086: Stampedes and cold cache performance issues with css/js aggregation
Comment #3
alexpottThe 10.0.x patch is necessary because PHPStan ignores deprecations inside deprecated classes - so the easiest thing to do here is fix the deprecation in 10.0.x.
Comment #4
longwaveI thought this was a bit strange but the code is equivalent given the variable is set under the same circumstances a few lines above. This code could perhaps be refactored to be more concise but it's out of scope here.
Otherwise this has caught a minor bug and cleaned up some test code that we missed, so big +1 to PHPStan.
Comment #5
catchCommitted/pushed to 10.1.x and 10.0.x respectively, thanks!
Comment #6
mondrake