Drupal 10 readiness meeting / 31 October 2022 [#3317261]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3317261`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

hestenet (he/him)	Tim from the DA :wave::skin-tone-3:
andypost	Andy, contributor
Malik Kotob	Hello! Malik, contributor
Mike (he/him)	Mike, long time n00b.
longwave	Dave, UK
bircher	Fabian
Kristen Pol (she/her)	Kristen, California, catching up
Vighnesh Sadagopal	Vighneshh, India
wimleers (he/him)	:wave: Ghent, Belgium

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

Taran2L	hello, contrib is not able to run tests with php8.2
Malik Kotob	Add contributor section (i.e. for non-maintainers looking to contribute) with pertinent info to template for the automated D10 compatibility issues that get posted to contrib modules. (edited)
andypost	Deprecations in nightwatch are not caught by CI[#3318301]
andypost	Removal of attributes and contrib testing, not clear is it ok at RC stage parent of #3299859: Remove AllowDynamicProperties attribute from JoinPluginBase
Gábor Hojtsy (he/him)	@andypost I think your second suggested topic is covered by 2️⃣ and 4️⃣ ?
andypost	Yes, thank you
longwave	Remove Chromedriver as a dependency? #3317879: Remove Chromedriver as a JavaScript dependency
andypost	@longwave mentioned it in https://drupal.slack.com/archives/C014CT1CN1M/p1667247186616329?thread_t...
Kristen Pol (she/her)	I added this: https://drupal.slack.com/archives/C014CT1CN1M/p1667277512033829

2️⃣ Make it possible for contrib to run tests with PHP 8.2

Gábor Hojtsy (he/him)	Raised by @Taran2L
Taran2L	there is thread discussing https://drupal.slack.com/archives/C51GNJG91/p1666257742630159@hestenet (he/him) hi, is there a movement?
andypost	@Taran2L is there any issue to track the cause? #3314632: upgrade phpspec/prophecy to 1.16.0 to support PHP 8.2 I bet (edited)
hestenet (he/him)	The propechy thing is the underlying issue but in the meantime, I think I can do this: would it be possible to create a php8.2 drupalci environment with --ignore-platform-reqs so contrib is able to run tests on 8.2? I believe I saw something like this before
hestenet (he/him)	I'll see if I can do it today
Taran2L	@andypost yes, this is the issue and I bet @effulgentsia found a cause; thanks @hestenet (he/him)
andypost	@hestenet (he/him) I'm sure --ignore-platform-req=php is enough
bircher	Would it be possible to have a floating label, so that if I use this now it will trst with 8.3 when that is a thing?
hestenet (he/him)	Just about ready to deploy this, just a few things stacked up in our deploy queue.. #3318421: Add a php8.2_mysql8_ignore environment so that contrib can run tests on PHP 8.2 despite phpspec/prophecy#comment-14768542
hestenet (he/him)	@bircher That's actually not a bad idea... I'm not totally sure if it would work, but I'll look into it. Probably will still go ahead with this option as is for now.
hestenet (he/him)	@Taran2L this environment is now available
Taran2L	:thinking_face:
Taran2L	https://dispatcher.drupalci.org/job/drupal_contrib/625388/console
Taran2L	probably this is not the right composer call …
hestenet (he/him)	Hm... it did the build with:14:14:47 sudo -u www-data /usr/local/bin/composer install --prefer-dist --no-suggest --no-interaction --ignore-platform-reqs --working-dir /var/www/html
hestenet (he/him)	But maybe we need that in the later composer require commands as well?
hestenet (he/him)	Our previous version of this container didn't seem to need to do that..
Taran2L	as far as I understand it, first run is for core and then contrib is added as a seconf command (and that one lacks --ignore…)
andypost	used to test it https://www.drupal.org/pift-ci-job/2511197 but there's compatibility and even release
Taran2L	@andypost I think your error is slightly different - you test against 10.0.x, but module itself requires ^8.8 \|\| ^9
andypost	@Taran2L no, module requires all 3 versions already but composer pulling something outdated
hestenet (he/him)	Yeah, I'm not sure the older example we had ever worked for contrib, that may have only worked for core tests.
hestenet (he/him)	May still be possible to figure out, but not going to be as fast as I thought...
andypost	@hestenet (he/him) really strange, even after commit composer still reports wrong supported versions for masquerade (edited)
hestenet (he/him)	That is particularly weird, yes.
andypost	last run https://dispatcher.drupalci.org/job/drupal_contrib/625398/console
hestenet (he/him)	I may have to pick this up again tomorrow.
hestenet (he/him)	Looking at this again, after fixing the broken contrib testing caused by the Nightwatch update..
hestenet (he/him)	Certainly the packages endpoint has all the right stuff for Masquerade: https://packages.drupal.org/files/packages/8/p2/drupal/masquerade.json
hestenet (he/him)	This particular problem is going to be tough to solve - I am passing in new build options for the contrib part of the DrupalCI build definition, but there isn't prior code to do this in the DrupalCI codebase - the lsat time we did this it was only for core.
hestenet (he/him)	So it may be a while before I figure this out..
hestenet (he/him)	We can hope that phpspec/prophecy updates soon...
Taran2L	bummer :disappointed:

3️⃣ Two weeks to RC, Drupal 9.5 and 10 RC1 are both planned for the week of November 14! See timeline at https://www.drupal.org/about/core/policies/core-release-cycles/schedule#...

Gábor Hojtsy (he/him)	I think @longwave was about to open issues to update dependencies, those should also be RC blockers, not seen them tagged at https://www.drupal.org/project/issues/search?issue_tags=Drupal%2010%20rc... though
longwave	I did open them but did not tag them correctly, oops
longwave	On my phone, will fix when back at the computer
Gábor Hojtsy (he/him)	#3317874: Update dependencies for Drupal 10.0 is one of them? what’s the other one? 🙂
longwave	#3258933: [meta] Update JavaScript dependencies for Drupal 10
longwave	which reminds me, can we have a thread for JavaScript Chromedriver removal? Unsure who, if anyone, uses this: #3317879: Remove Chromedriver as a JavaScript dependency

4️⃣ RC blocker: PHP 8.2 support (edited)

Gábor Hojtsy (he/him)	Maybe the same as 2️⃣ ?
Gábor Hojtsy (he/him)	Issue at #3283358: [META] Make Drupal 9/10 compatible with PHP 8.2
andypost	I think we should re-title it to D10 and except Prophecy (which means core can't be installed for contrib testing), the main question is clean-up of attributes
andypost	For example #3299859: Remove AllowDynamicProperties attribute from JoinPluginBase require to add new class which is not allowed atm
andypost	So more commiter's attension required on backport of 10.1.x commits
catch	@andypost for something like that I think it should just be 10.1.x only at this point.
wimleers (he/him)	Wait I thought 8.2 support was done?!
wimleers (he/him)	Per #3283358: [META] Make Drupal 9/10 compatible with PHP 8.2#comment-14766019
andypost	yes, it's done with workaround (using attributes)
catch	@wimleers (he/him) core has support. Prophecy doesn't, in a way that affects contrib testing but not core's.
catch	@wimleers (he/him) just realised which thread I'm replying to. There's several dynamic properties follow-ups but none of them block 8.2 support and they might not even block 9.0 support.
wimleers (he/him)	That’s what I thought — thanks for confirming! :+1:

5️⃣ RC blocker: Symfony 6.2 compatibility (edited)

Gábor Hojtsy (he/him)	Issue at #3284422: [META] Symfony 6.2 compatibility
andypost	There's some work required after beta2, as near 1k tests failed

6️⃣ RC blocker: Decide on strategy for when and how to require Composer 2.1 or higher (for Automatic Updates in Core) (edited)

Gábor Hojtsy (he/him)

Issue at #3313486: Decide when to require Composer runtime ^2.1 (needed by Automatic Updates)

7️⃣ RC blocker: Private file caching regression (edited)

Gábor Hojtsy (he/him)	Issue at #3312198: Regression concerning the cache of private files
catch	This has gone around the houses a couple of times, but now a green patch that I think is ready for review.If there's something non-trivially wrong with it, then I think we need to roll back the issue that introduced the regression.#3312198: Regression concerning the cache of private files#comment-14768894

8️⃣ RC blocker: CKE5 dictation/IME not working on some platforms

Gábor Hojtsy (he/him)	Issue at #3283802: Update CKEditor 5 to 35.3.2 to fix voice control/IME on some platforms
wimleers (he/him)	Got some good news on this on Thursday! :blush: :+1:
Gábor Hojtsy (he/him)	Yay! What’s the news? 🙂
wimleers (he/him)	It’s on the issue obviously: #3283802: Update CKEditor 5 to 35.3.2 to fix voice control/IME on some platforms#comment-14772959
wimleers (he/him)	:nerd_face:
wimleers (he/him)	The CKEditor 5 team has indicated that they will do an interim patch release, around the 23rd of November.
Gábor Hojtsy (he/him)	Thanks for posting here, it will be part of the saved notes then :)

9️⃣ RC blocker: Update dependencies for Drupal 10.0

Gábor Hojtsy (he/him)

Issue at #3317874: Update dependencies for Drupal 10.0

🔟 RC blocker: Update JavaScript dependencies for Drupal 10

Gábor Hojtsy (he/him)	Issues at #3258933: [meta] Update JavaScript dependencies for Drupal 10
andypost	Needs @lauriii on #3317879: Remove Chromedriver as a JavaScript dependency as subissue to simplify dependencies
Gábor Hojtsy (he/him)	Opened 1️⃣ 3️⃣ for the subtopic as well.

1️⃣ 1️⃣ Deprecations in nightwatch are not caught by CI

Gábor Hojtsy (he/him)	Raised by @andypost
Gábor Hojtsy (he/him)	Issue at #3318301: Fix deprecations of Nightwatch
andypost	I think it needs infra follow-up to catch deprecations from js, any idea @hestenet (he/him)
hestenet (he/him)	I'm not sure what infra changes would be needed.... any ideas?
andypost	at least to catch and extract deprections, count them

1️⃣ 2️⃣ Update project update bot issue template with info for non-maintainers looking to contribute

Gábor Hojtsy (he/him)	Raised by @Malik Kotob
Malik Kotob	Thanks @Gábor Hojtsy (he/him)! So I went into the issue queue for a few contrib modules to help out and noticed that the automated issue that is posted doesn't have a section that is specific to those looking to contribute.Info you might find in this section:Common links to Drupal contrib/patch flows and expectationsHow to test compatibility patchesLink to the D10 environment setup etc
Malik Kotob	I just happened to stumble on the last two pages when looking at a comment by Kristen Pol on one of these auto-posted issues
Gábor Hojtsy (he/him)	Hm are those specific to the automated bot patches? (Normally you would not find such guidance in other issues either?)
Malik Kotob	Not necessarily, but what is unique is that when these D9/D10 (in the future D11) porting events take place, we as a community have an influx of folks looking to contribute/further along the compatibility effort. So the latter two links are especially helpful because they help give immediate tips to folks otherwise not familiar with contribution.
Malik Kotob	So in the remaining tasks section is where it feels like there lies the biggest opportunity to expand upon these bullets. Or at least link to the right pages with expectations on what "thoroughly test the patch" means (i.e. it means test it in accordance with our recommended setup here - https://www.drupal.org/community-initiatives/contribution-events-initiat...)Remaining tasksUsing the patchesApply the latest patch in the comments by Project Update Bot or human contributors that made it better.Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.Providing feedbackIf there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Kristen Pol (she/her)	Personally, I love this idea :heart_eyes: I had thought before it would be great to point to some of these resources as well
Malik Kotob	@Gábor Hojtsy (he/him) what say you? 🙂 Unless there's something being overlooked, it seems like more resources could only help the community? Alternatively we should be making these resources prominent somehow on all issue types, but I'd imagine that's beyond the scope of the d10 readiness conversation
Gábor Hojtsy (he/him)	Can we update a page that is already linked in the summary with the info? Last time we mass updated 6k+ issues some top contrib maintainers complained hard that their tracker and email inbox was destroyed.
Malik Kotob	Ah I wasn't necessarily thinking to retroactively update issues. I was thinking moreso updating the template for the future for the reason you cited.I think it makes sense though to update a page that is already linked
Gábor Hojtsy (he/him)	That would give the biggest bang for the buck 🙂 Like updating the user page of the bot, which I think is already linked. Although that loads quite slow.
Malik Kotob	hmm yeah actually looking at the existing links it wouldn't exactly jump out at a contributor that one of those will have the info they need for getting ramped up on contributionThat's okay. Maybe this page makes the most sense https://www.drupal.org/about/core/blog/the-project-update-bot-is-being-r... for now? And then maybe I could submit a patch for improving the template for future auto-posting efforts? Where would that codebase be?
Malik Kotob	Actually I just stumbled upon this as well @Kristen Pol (she/her) #3304342: Update Project Update Bot templates to provide better status recommendations. It seems like this thread is kinda related? Since list item #2 under the proposed resolution mentions improvements to be more informative for contributors:2. Consider also adding some information to contributors that recommends they check if there is already a compatible version before reviewing/testing and, if finding one, adding a comment and moving to Active.
Kristen Pol (she/her)	I’ll see if I can review this properly tonight but 1) agree we don’t need a bot run for this… it’ll be for the future, 2) agree we can update some existing places as well, and 3) I’ll be updating and hopefully simplifying/improving the docs prior to the next porting day so possibly next week

1️⃣ 3️⃣ Remove Chromedriver as a JS dependency

Gábor Hojtsy (he/him)	Raised by @longwave
Gábor Hojtsy (he/him)	#3317879: Remove Chromedriver as a JavaScript dependency

1️⃣ 4️⃣ Thanks all for coming this week, this is the end of the meeting! See you next week!

1️⃣ 5️⃣ Adding one more: Still looking for mentors for the November porting day. See thread for signup form.

Kristen Pol (she/her)	https://docs.google.com/forms/d/e/1FAIpQLSfcd7FjdaxfisXE6WFGTTEtZaVeSnQW...
FeyP	@Kristen Pol (she/her) How can I specify the day(s) I would be available? I see only time frames, no dates.
Kristen Pol (she/her)	@FeyP Ah… it’s on the event page… cc @gambryhttps://www.drupal.org/community/events/drupal-10-global-porting-day-nov...
Kristen Pol (she/her)	Oh! You mean which of the days
Kristen Pol (she/her)	@gambry would you add a text box or option for which day(s)?
Kristen Pol (she/her)	@FeyP for now, you can let me know here and I’ll note it, thanks
gambry	@Kristen Pol (she/her) will do.
gambry	Added.
FeyP	Thanks @gambry . A potential problem might be if mentors want to help on multiple days but different time slots on each day. For that you'd either need to add the date to the hours available options and add more options to that field or have one "hours available" field per day. Having said that, the new setup already works for my use case, so I'll register later this week once I have figured out the exact hours that would work for me. Thanks again!
gambry	@FeyP, to me, this whole days VS hours VS timezones thing is super confusing. The deeper we go, the more difficult it gets.Before there was a nice spreadsheet where mentors could simply mark the slots they liked.Let’s just remember to feedback on all these notes on the next #contribution-events online meeting :+1:
FeyP	Yeah, with different time zones and stuff it's always complicated. I guess we made that even more complicated by deciding the next event would span multiple days instead of just one... As a developer, who has had the "pleasure" to work with dates and timezones before, I definitely feel your pain :wink: .
gambry	lol. :smile: :handshake:
Kristen Pol (she/her)	I can make a spreadsheet again if that’s better… I did that for the July event
Kristen Pol (she/her)	Let me know and I can do when I’m back home tonight
gambry	No @Kristen Pol (she/her), don’t worry. It’s OK with what we have.Next time we can review our practices. I’m sure having back the spreadsheet has its CONs too, so let’s validate the best option during the next retrospective.But thank you for volunteering. Your commitment is endless! ❤️ :thankful: