Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
As of 8.2 callables changed https://wiki.php.net/rfc/deprecate_partially_supported_callables
Mostly all places been fixed in #3299327: Replace deprecated static::method() calls for PHP 8.2 except one place
Steps to reproduce
See #3295821-91: Ignore: patch testing issue for PHP 8.2 attributes
core/modules/views/src/Views.php
- $views = call_user_func("static::get{$filter}Views");
+ $views = call_user_func(static::class . "::get{$filter}Views");
Proposed resolution
Change syntax to supported PHP versions
Remaining tasks
- collect all changes from testing issue #3295821-91: Ignore: patch testing issue for PHP 8.2 attributes
- make sure tests pass on PHP 8.2
- review/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
no
Comment | File | Size | Author |
---|---|---|---|
#4 | 3309750-4.patch | 550 bytes | andypost |
Comments
Comment #2
BerdirWe already had an issue for most of these but we missed this one.
Comment #3
andypostIIRC the issue been fixed but with follow-up to improve via rector - will dig later today
Comment #4
andypostThere's postponed #3259716: Replace usages of static::class . '::methodName' to first-class callable syntax static::method(...) but there's only one place to fix for 8.2 and the related issue if for making a common syntax for all core
Comment #5
andypostre-title to point the scope
Comment #6
BerdirYes, lets do just do this for now.
Comment #8
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!