Problem/Motivation

It would be nice to provide favicons and related configuration with the wxt_bootstrap starterkit for new custom themes. This is something I find myself doing each time I setup a new custom theme.

Proposed changes:

  • Replace favicon.ico with version from Canada.ca
  • Add missing favicon-mobile.png from Canada.ca (currently get 404 on this image)
  • Update /config/install/THEMENAME.settings.yml to use favicons from theme by default
CommentFileSizeAuthor
#2 wxt-bootstrap-starterkit-favicons-3304675-2.patch14.5 KBsmulvih2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smulvih2 created an issue. See original summary.

smulvih2’s picture

smulvih2
Location Canada 🍁
CreditAttribution: smulvih2 at OpenPlus, Cinder Systems Corp. commented
Status: Active » Needs review
FileSize
wxt-bootstrap-starterkit-favicons-3304675-2.patch14.5 KB

Patch to implement changes.

smulvih2’s picture

smulvih2
Location Canada 🍁
CreditAttribution: smulvih2 at OpenPlus, Cinder Systems Corp. commented

The patch file looks a bit strange, but I tested and it brings the new images into the starterkit as expected.

sylus’s picture

sylus CreditAttribution: sylus commented
Status: Needs review » Fixed

Committed and attributed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.