Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
See remaining test failures on https://www.drupal.org/pift-ci-job/2447967
We had to do similar for modules, for example in #3264435: Help topics and rest don't filter out deprecated modules when testing.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3302800
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #5
quietone CreditAttribution: quietone at PreviousNext commentedI only had time to fix two tests. In the MR seven is deprecated to make it easy to see what else fails.
Comment #6
nod_should we create a helper to do that instead of duplicating the code in different places?
Comment #7
catchWe ended up not doing this in the similar modules issues because the lists were used in slightly different ways (i.e. sometimes experimental modules were filtered out too, sometimes not). Don't think it hurts to add a helper if it's useful and straightforward, but also if it's only four or five tests wouldn't block on it - could be done in a follow-up.
Comment #8
nod_Comment #9
nod_Pushed a few updates, bit of arm flailing in some places to be honest, let's see what it does.
Comment #10
catchSome of the changes are already covered by #3281434: Update System module tests to not use Bartik and Seven, which should remove the last explicit references.
We only need to worry about the implicit use of the themes when it's looping over everything it finds here.
Comment #11
catch#3302800: Core tests need to filter out deprecated themes when looping over all themes landed so this needs a rebase (which should mean some of the changes to system tests are no-longer relevant).
Also with Seven tests we can do
@group legacyinstead of skipping the tests.Comment #12
quietone CreditAttribution: quietone at PreviousNext commentedThat was the rebase
Comment #13
quietone CreditAttribution: quietone at PreviousNext commentedI checked back with what was done for Color and the @legacy was added in the issue that did the deprecation. I think we should do the same here.
Comment #14
quietone CreditAttribution: quietone at PreviousNext commentedIn ResolvedLibraryDefinitionsFilesMatchTest the themes to be deprecated have been removed from the $allThemes, the list of themes to test. That means the filter done in code can be removed (it was wrong anyway) and has been removed.
Drupal\KernelTests\Config\DefaultConfigTest reports a deprecation notice because help_topics has an optional config, block.block.seven_help_search.yml. What happens to that?
And this MR has the seven deprecated to find the errors, that will have to be removed when the tests are updated.
Comment #15
catchI think we probably need to remove that, at least unless we can move it to optional config in seven module?
Comment #17
longwaveRemoved irrelevant RDF mapping and reverted the change in SevenLayoutBuilderTest.
Opened #3303787: Move core/modules/help_topics/config/optional/block.block.seven_help_search.yml to Seven
Comment #18
catchThis is RTBC for me except for removing the Seven deprecation from the MR.
Comment #19
nod_per #18 :)
Comment #21
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!