Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In #3261004: Remove deprecated code from the migration system we removed the deprecation of not adding the $module_handler
argument in \Drupal\migrate_drupal_ui\Form\ReviewForm::__construct
.
We did however forgot to remove the = NULL
-bit from the argument itself:
public function __construct(StateInterface $state, MigrationPluginManagerInterface $migration_plugin_manager, PrivateTempStoreFactory $tempstore_private, MigrationState $migrationState, ConfigFactoryInterface $config_factory, ModuleHandlerInterface $module_handler = NULL) {
Let's fix that here.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#3 | 3302096-3.patch | 1.18 KB | Spokje |
|
Comments
Comment #2
SpokjeTo The Powers That Be: Please credit @mondrake for pointing out this issue.
Comment #3
SpokjeComment #4
SpokjeComment #5
SpokjeComment #6
mondrakeCruft removal.
Comment #7
alexpottCommitted and pushed f2c6592768 to 10.1.x and 41052d2733 to 10.0.x. Thanks!
Comment #10
quietone CreditAttribution: quietone at PreviousNext commentedJust changing component
Comment #11
benjifisherI am crediting @mondrake as requested in #2.