Problem/Motivation

In #3261004: Remove deprecated code from the migration system we removed the deprecation of not adding the $module_handler argument in \Drupal\migrate_drupal_ui\Form\ReviewForm::__construct.

We did however forgot to remove the = NULL-bit from the argument itself:

  public function __construct(StateInterface $state, MigrationPluginManagerInterface $migration_plugin_manager, PrivateTempStoreFactory $tempstore_private, MigrationState $migrationState, ConfigFactoryInterface $config_factory, ModuleHandlerInterface $module_handler = NULL) {

Let's fix that here.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3302096-3.patch1.18 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

To The Powers That Be: Please credit @mondrake for pointing out this issue.

spokje’s picture

StatusFileSize
new1.18 KB
spokje’s picture

Status: Active » Needs review
spokje’s picture

Issue tags: +Deprecation Removal
mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Cruft removal.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed f2c6592768 to 10.1.x and 41052d2733 to 10.0.x. Thanks!

  • alexpott committed f2c6592 on 10.1.x
    Issue #3302096 by Spokje: Incorrect deprecation removal in \Drupal\...

  • alexpott committed 41052d2 on 10.0.x
    Issue #3302096 by Spokje: Incorrect deprecation removal in \Drupal\...
quietone’s picture

Component: comment.module » migration system

Just changing component

benjifisher’s picture

I am crediting @mondrake as requested in #2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.