Problem/Motivation
In #3261004: Remove deprecated code from the migration system we removed the deprecation of not adding the $module_handler argument in \Drupal\migrate_drupal_ui\Form\ReviewForm::__construct.
We did however forgot to remove the = NULL-bit from the argument itself:
public function __construct(StateInterface $state, MigrationPluginManagerInterface $migration_plugin_manager, PrivateTempStoreFactory $tempstore_private, MigrationState $migrationState, ConfigFactoryInterface $config_factory, ModuleHandlerInterface $module_handler = NULL) {
Let's fix that here.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comments
Comment #2
spokjeTo The Powers That Be: Please credit @mondrake for pointing out this issue.
Comment #3
spokjeComment #4
spokjeComment #5
spokjeComment #6
mondrakeCruft removal.
Comment #7
alexpottCommitted and pushed f2c6592768 to 10.1.x and 41052d2733 to 10.0.x. Thanks!
Comment #10
quietone commentedJust changing component
Comment #11
benjifisherI am crediting @mondrake as requested in #2.