Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new4.05 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
dharti patel’s picture

Assigned: Unassigned » dharti patel
Issue summary: View changes

Hello,

Thanks for the auto-bot patch, I will review the patch.

Thanks!

dharti patel’s picture

Assigned: dharti patel » Unassigned
Status: Needs review » Needs work
StatusFileSize
new112.19 KB

Hello,

After applying the patch, still getting errors for drupal 10 compatibilities as shown in the attached screenshot.
Hence shifting the issue status to Needs work.

Thanks!

reenaraghavan made their first commit to this issue’s fork.

reenaraghavan’s picture

StatusFileSize
new4.49 KB
new383 bytes
shivam_tiwari’s picture

Status: Needs work » Needs review

Bootstrap Cloud is also available for drupal 10 now. Please check project page https://www.drupal.org/project/bootstrap_cloud

yas’s picture

Status: Needs review » Needs work

@reenaraghavan

Thank you for supplying the patch. Can you remove the following changes? The patch can be applied to both 5.x and 6.x. but we don't support Drupal 10 in drupal/bootstrap_cloud:5.x.

<code>-core_version_requirement: '^9.3'
+core_version_requirement: '^9.3 || ^10'

Thanks

shubham_jain’s picture

Status: Needs work » Needs review
StatusFileSize
new4.05 KB
new366 bytes

Hi everyone, I noticed that nobody replied to the @yas. So created the updated patch file and attached interdiff file as well.

@yas, please review and verify.

yas’s picture

Status: Needs review » Needs work

@shubham_jain

Thank you for the patch. Basically, we should use Dependency Injection instead of using the static call such as Drupal::service()

So can you please create MR? Then we can put the review comments from the GitLab UI.

shubham_jain’s picture

hi @yas, will work on it.

shubham_jain’s picture

Status: Needs work » Needs review

Hi @ yas, I have updated the MR please review and verify.

yas’s picture

Status: Needs review » Needs work

@shubham_jain

Thank you for the update. I posted my comment. Thanks!

yas’s picture

Version: 5.x-dev » 6.x-dev
shubham_jain’s picture

Hi @yas, thanks for the correcting me. Please review.

yas’s picture

Status: Needs work » Reviewed & tested by the community

@shubham_jain

Thank you for the update. It looks good to me now.  I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

NOTE: Please change the Status to Needs review so that you can let us know the patch is ready to review.

  • yas committed 08338769 on 6.x authored by shubham_jain
    Issue #3296676 by shubham_jain, reenaraghavan, yas, Project Update Bot,...

  • yas committed f2bb2f60 on 5.x authored by shubham_jain
    Issue #3296676 by shubham_jain, reenaraghavan, yas, Project Update Bot,...
shubham_jain’s picture

Hi @yas, sorry forgot to change that.

Thank you.

yas’s picture

Status: Reviewed & tested by the community » Fixed

@shubham_jain

No problem, thank you for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.