Problem/Motivation

#date_date_callbacks callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. Support for this callback implementation is deprecated in drupal:9.3.0 and will be removed in drupal:10.0.0.

Steps to reproduce

Proposed resolution

Throw an exception when an untrusted date callback is encountered in Drupal 10.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3293077-2.patch10.5 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Title: Remove deprecated untrusted #date_date_callbacks » Enforce TrustedCallbackInterface in #date_date_callbacks
Status: Active » Needs review
FileSize
3293077-2.patch10.5 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue tags: +Drupal 10, +Deprecation Removal
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

LGTM.

  • catch committed 3fc5c8a on 10.0.x 
    Issue #3293077 by longwave: Enforce TrustedCallbackInterface in #...
  • catch committed 29ae0b6 on 10.1.x
    Issue #3293077 by longwave: Enforce TrustedCallbackInterface in #...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.