Olivero currently hard-codes the toolbar height, checking for CSS classes, etc. This is brittle.

This issue is to refactor the CSS to take advantage of the Drupal displace utilities CSS variables. Along the way, we'll fix some edge case issues where components might not show properly in various toolbar configurations.

Testing instructions

Test that the header sits directly below the top toolbar in the following conditions

  • On page load
    • When not logged in
    • When logged in and bottom toolbar is active
    • When logged in and bottom toolbar is not active
    • When logged in and bottom toolbar is in vertical orientation
  • When scrolled down the page so that the header is fixed
    • When not logged in
    • When logged in and bottom toolbar is active
    • When logged in and bottom toolbar is not active
    • When logged in and bottom toolbar is in vertical orientation
  • RTL versions of the above (you need to modify the dir attribute within the HTML tag using developer tools)
  • Narrow width (mobile menu) versions of the above.
    • When in narrow width, also open close the primary menu and be sure it works as expected. Be sure to test RTL versions and all toolbar variations.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Status: Active » Needs review
FileSize
18.77 KB

Patch attached. Still need to update summary with testing instructions

mherchel’s picture

Issue summary: View changes

Adding testing instructions

mherchel’s picture

Issue summary: View changes
mherchel’s picture

FileSize
19.95 KB

Minor change that ensures that if 1) scrolled down so the header is fixed and 2) toolbar is open and in vertical orientation, the menu width adjusts.

andy-blum’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
8.33 MB

This looks good, screenshots attached.

  • lauriii committed cfc735d on 10.1.x
    Issue #3291729 by mherchel, andy-blum: Refactor Olivero styles to use...

  • lauriii committed 6b2c357 on 10.0.x
    Issue #3291729 by mherchel, andy-blum: Refactor Olivero styles to use...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Committed cfc735d and pushed to 10.1.x. Also cherry-picked to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.