Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Olivero currently hard-codes the toolbar height, checking for CSS classes, etc. This is brittle.
This issue is to refactor the CSS to take advantage of the Drupal displace utilities CSS variables. Along the way, we'll fix some edge case issues where components might not show properly in various toolbar configurations.
Testing instructions
Test that the header sits directly below the top toolbar in the following conditions
- On page load
- When not logged in
- When logged in and bottom toolbar is active
- When logged in and bottom toolbar is not active
- When logged in and bottom toolbar is in vertical orientation
- When scrolled down the page so that the header is fixed
- When not logged in
- When logged in and bottom toolbar is active
- When logged in and bottom toolbar is not active
- When logged in and bottom toolbar is in vertical orientation
- RTL versions of the above (you need to modify the dir attribute within the HTML tag using developer tools)
- Narrow width (mobile menu) versions of the above.
- When in narrow width, also open close the primary menu and be sure it works as expected. Be sure to test RTL versions and all toolbar variations.
Comment | File | Size | Author |
---|---|---|---|
#6 | screenshots.zip | 8.33 MB | andy-blum |
#5 | 3291729-5.patch | 19.95 KB | mherchel |
|
Comments
Comment #2
mherchelPatch attached. Still need to update summary with testing instructions
Comment #3
mherchelAdding testing instructions
Comment #4
mherchelComment #5
mherchelMinor change that ensures that if 1) scrolled down so the header is fixed and 2) toolbar is open and in vertical orientation, the menu width adjusts.
Comment #6
andy-blumThis looks good, screenshots attached.
Comment #9
lauriiiCommitted cfc735d and pushed to 10.1.x. Also cherry-picked to 10.0.x. Thanks!