Automated Drupal 10 compatibility fixes

Adding patch to make the module D10 Compatible.
Drupal 10 Compatibility

Thank you for the patch @dvym,
I have reviewed and checked patch #3 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 and the config page on 10 have been attached for reference:

teste

Subscribing

Can we get this committed and released as a drupal 10 compatible release please? This is blocking the drupal 10 upgrade for us.

I think we will need this very soon aswel. I see the patch is 11 months old now.

Is this module being actively updated with patches?

Pretty sad. D9 EOL is approaching fast. There is a working patch. OneTrust just doesn't commit it. Yeah, there's cookiepro_plus, but it's way more complicated than necessary for most purposes. Considering that CookiePro is a commerical product this "underwhelming" level of support is a bit disappointing IMHO.

@rgpublic If you can explain how cookiepro_plus is too complicated/overwhelming for many use-cases in our issue queue, we can see what we can do to make it easier to setup, explain better what the basics are, ....

I created cookiepro_plus because we (at Calibrate) found that this cookiepro module is insufficient for most of our cases and doesn't allow well for config differences between environments (local, dev, staging, production).

As explained in other issues of this module, I tried to work with OneTrust over the timespan of approx a year to get our findings into this module and work together towards one actively maintained solution, but they didn't care, could/would not spare a few hours month to get this done, and so we went our own way.

@CookiePro you need to merge the MR and add a tag, then "Add a new release" on the project page selecting this tag.

If you want to use this:

Edit the composer.json file in your project root. Add this in the "repositories": [ section, as first item:

        {
            "type": "package",
            "package": {
                "name": "drupal/cookiepro",
                "type": "drupal-module",
                "version": "2.0.1",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/issue/cookiepro-3286785.git",
                    "reference": "5d0d9dc2ba67c871eeb5c7dee3c3ff11dbf7a955"
                }
            }
        },

Now add this version to your project:

composer require drupal/cookiepro:2.0.1

The official way to do this is to use the lenient endpoint that gets the latest version plus the patch and tells Composer it's okay: https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient...

Thanks Leymannx. I hadn't heard of that yet. I did found and tried using chx/drupal-issue-fork but for some reason that did not work for me.

So the workinbg steps are:

- Add composer drupal lenient:
composer require mglaman/composer-drupal-lenient

- Add the patch to your composer "patches": { section:

            "drupal/cookiepro": {
                "#3286785": "https://www.drupal.org/files/issues/2022-06-15/cookiepro.2.0.1.rector.patch"
            }

- Get the cookiepro module with the patch included:
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/cookiepro"]'
composer require drupal/cookiepro:2.0.1

seems to work !

I became maintainer and just tagged 2.1.0. This issue is fixed. Leaving open for future rector fixes.

Great work, thank you! Just when I was about to update all our projects to use cookiepro_plus for D10 compatibility.
I do find the setup for the cookiepro_plus a little bit better, but most current projects have the cookiepro module already so its nice that its now easily upgradable for D10.

I thought that cookiepro_plus was created because of a lack of development on the cookiepro module.
Now that you are a maintainer, it might be wise to check if we really need 2 separate cookiepro modules. Maybe they can be merged or one can go in favor of the other ? That would be less confusing for people looking to add cookiepro into their drupal project.